[UserClassifier] Inject a clock

[UserClassifier] Inject a clock

This CL injects a clock into UserClassifier. This is a preparation work
before introducing a unit-test for UserClassifier.

BUG=699027
Review-Url: https://codereview.chromium.org/2759423003
Cr-Commit-Position: refs/heads/master@{#458373}
Committed: https://chromium.googlesource.com/chromium/src/+/27b02c10c64ced00dc51231fb856d3d8c5afb33b

[jkrcal, 2017-03-21 09:35:58]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[jkrcal, 2017-03-21 09:36:11]

jkrcal@chromium.org changed reviewers:
+ treib@chromium.org

[jkrcal, 2017-03-21 09:36:11]

Marc, could you PTAL?

[commit-bot: I haz the power, 2017-03-21 09:36:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2017-03-21 09:43:21]

lgtm

https://codereview.chromium.org/2759423003/diff/1/components/ntp_snippets/con...
File components/ntp_snippets/content_suggestions_service.cc (right):

https://codereview.chromium.org/2759423003/diff/1/components/ntp_snippets/con...
components/ntp_snippets/content_suggestions_service.cc:38:
user_classifier_(pref_service, base::MakeUnique<base::DefaultClock>()),
Hm, eventually we should probably pass in the UserClassifier directly. But this
is fine for now :)

[jkrcal, 2017-03-21 09:46:59]

Thanks!

https://codereview.chromium.org/2759423003/diff/1/components/ntp_snippets/con...
File components/ntp_snippets/content_suggestions_service.cc (right):

https://codereview.chromium.org/2759423003/diff/1/components/ntp_snippets/con...
components/ntp_snippets/content_suggestions_service.cc:38:
user_classifier_(pref_service, base::MakeUnique<base::DefaultClock>()),
On 2017/03/21 09:43:20, Marc Treib wrote:
> Hm, eventually we should probably pass in the UserClassifier directly. But
this
> is fine for now :)

Agreed. There's also a lot of duplication in the unit-tests. This is for a
further CL. I make a note in the bug.

[commit-bot: I haz the power, 2017-03-21 10:22:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 10:22:04]

Dry run: This issue passed the CQ dry run.

[jkrcal, 2017-03-21 11:14:14]

The CQ bit was checked by jkrcal@chromium.org

[commit-bot: I haz the power, 2017-03-21 11:14:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 11:18:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490094854971500, "parent_rev":
"241fad6fdac74b820fa21e29652bbae49239840e", "commit_rev":
"27b02c10c64ced00dc51231fb856d3d8c5afb33b"}

[commit-bot: I haz the power, 2017-03-21 11:19:16]

Description was changed from

==========
[UserClassifier] Inject a clock

This CL injects a clock into UserClassifier. This is a preparation work
before introducing a unit-test for UserClassifier.

BUG=699027
==========

to

==========
[UserClassifier] Inject a clock

This CL injects a clock into UserClassifier. This is a preparation work
before introducing a unit-test for UserClassifier.

BUG=699027

Review-Url: https://codereview.chromium.org/2759423003
Cr-Commit-Position: refs/heads/master@{#458373}
Committed:
https://chromium.googlesource.com/chromium/src/+/27b02c10c64ced00dc51231fb856...
==========

[commit-bot: I haz the power, 2017-03-21 11:19:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/27b02c10c64ced00dc51231fb856...