Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Unified Diff: components/ntp_snippets/user_classifier.cc

Issue 2759423003: [UserClassifier] Inject a clock (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/user_classifier.cc
diff --git a/components/ntp_snippets/user_classifier.cc b/components/ntp_snippets/user_classifier.cc
index 8686700fd642acde4262a15d44b80824fb00b8e4..db91d804792f7820d3308d286a9f8da28374452d 100644
--- a/components/ntp_snippets/user_classifier.cc
+++ b/components/ntp_snippets/user_classifier.cc
@@ -10,6 +10,7 @@
#include "base/metrics/histogram_macros.h"
#include "base/strings/string_number_conversions.h"
+#include "base/time/clock.h"
#include "components/ntp_snippets/features.h"
#include "components/ntp_snippets/pref_names.h"
#include "components/prefs/pref_registry_simple.h"
@@ -181,8 +182,10 @@ double GetMetricValueForEstimateHoursBetweenEvents(
} // namespace
-UserClassifier::UserClassifier(PrefService* pref_service)
+UserClassifier::UserClassifier(PrefService* pref_service,
+ std::unique_ptr<base::Clock> clock)
: pref_service_(pref_service),
+ clock_(std::move(clock)),
discount_rate_per_hour_(GetDiscountRatePerHour()),
min_hours_(GetMinHours()),
max_hours_(GetMaxHours()),
@@ -353,8 +356,8 @@ double UserClassifier::GetHoursSinceLastTime(Metric metric) const {
}
base::TimeDelta since_last_time =
- base::Time::Now() - base::Time::FromInternalValue(pref_service_->GetInt64(
- kLastTimeKeys[static_cast<int>(metric)]));
+ clock_->Now() - base::Time::FromInternalValue(pref_service_->GetInt64(
+ kLastTimeKeys[static_cast<int>(metric)]));
return since_last_time.InSecondsF() / 3600;
}
@@ -364,7 +367,7 @@ bool UserClassifier::HasLastTime(Metric metric) const {
void UserClassifier::SetLastTimeToNow(Metric metric) {
pref_service_->SetInt64(kLastTimeKeys[static_cast<int>(metric)],
- base::Time::Now().ToInternalValue());
+ clock_->Now().ToInternalValue());
}
double UserClassifier::GetMetricValue(Metric metric) const {

Powered by Google App Engine
This is Rietveld 408576698