Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(74)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: services/preferences/public/cpp/DEPS
Issue
2759413002
:
Move PrefStoreManagerImpl into //services/preferences. (Closed)
Patch Set: Update newly-added test.
Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/BUILD.gn
chrome/browser/profiles/profile_impl.cc
services/preferences/BUILD.gn
services/preferences/pref_service_factory_unittest.cc
services/preferences/pref_store_manager_impl.h
services/preferences/pref_store_manager_impl.cc
services/preferences/public/cpp/BUILD.gn
services/preferences/public/cpp/DEPS
services/preferences/public/cpp/pref_service_main.h
services/preferences/public/cpp/pref_service_main.cc
services/preferences/public/cpp/pref_store_manager_impl.h
services/preferences/public/cpp/pref_store_manager_impl.cc
View unified diff
|
Download patch
« no previous file with comments
|
« services/preferences/public/cpp/BUILD.gn
('k') |
services/preferences/public/cpp/pref_service_main.h »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 include_rules = [
1 include_rules = [
2 "+components/prefs",
2 "+components/prefs",
3 "+components/user_prefs/tracked",
3 "+components/user_prefs/tracked",
4
"-services/preferences",
5
"+services/preferences/public",
4 ]
6 ]
7
specific_include_rules = {
8
"pref_service_main\.cc": [
9
"+services/preferences",
10
],
11
}
OLD
NEW
« no previous file with comments
|
« services/preferences/public/cpp/BUILD.gn
('k') |
services/preferences/public/cpp/pref_service_main.h »
('j') |
no next file with comments »
Issue 2759413002: Move PrefStoreManagerImpl into //services/preferences. (Closed)
Created 3 years, 9 months ago by Sam McNally
Modified 3 years, 9 months ago
Reviewers: Mike Lerman, tibell
Base URL:
Comments: 4
This is Rietveld
408576698