Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issue 2759393004: Make isolate server look better on bigger screens (Closed)

Created:
3 years, 9 months ago by kjlubick
Modified:
3 years, 9 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Make isolate server look better on bigger screens Using container-fluid for the outside tells bootstrap we want to use as much width as the screen has (minus some padding). Additionally, we adjust the height of the iframe after loading to make it expand to its full height, making things look nicer. BUG=703581 BUG=698740 Review-Url: https://codereview.chromium.org/2759393004 Committed: https://github.com/luci/luci-py/commit/9e955a3cbcc9e019494ce7950497109bc31690b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M appengine/isolate/templates/base.html View 1 chunk +1 line, -1 line 0 comments Download
M appengine/isolate/templates/browse.html View 2 chunks +10 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
kjlubick
Before (on a 2560x1440 screen) home page: https://screenshot.googleplex.com/MQXLdQTQQy6 text isolate: https://screenshot.googleplex.com/YUa91ANjm57 large isolated image: https://screenshot.googleplex.com/LyZJOnZnK4A ...
3 years, 9 months ago (2017-03-21 17:48:00 UTC) #2
M-A Ruel
partially rs lgtm
3 years, 9 months ago (2017-03-22 01:25:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759393004/1
3 years, 9 months ago (2017-03-22 11:56:13 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 11:58:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/9e955a3cbcc9e019494ce7950497109bc31690b3

Powered by Google App Engine
This is Rietveld 408576698