Fixing bad casting between DOMTypedArray objects

Fixing bad casting between DOMTypedArray objects

Fixing bad casting between DOMTypeArray objects by overriding
ImageDataColorSettings.ImageDataStorageFormat when external data array is
provided.

BUG=702982
Review-Url: https://codereview.chromium.org/2759113003
Cr-Commit-Position: refs/heads/master@{#458504}
Committed: https://chromium.googlesource.com/chromium/src/+/03666b25531fd69b88fc2d6685d639cd893a79f0

[zakerinasab, 2017-03-20 20:36:50]

Description was changed from

==========
Fixing bad casting between DOMTypedArray objects

Fixing bad casting between DOMTypeArray objects by overriding
ImageDataColorSettings.ImageDataStorageFormat when external data array is
provided.

BUG=702982
==========

to

==========
Fixing bad casting between DOMTypedArray objects

Fixing bad casting between DOMTypeArray objects by overriding
ImageDataColorSettings.ImageDataStorageFormat when external data array is
provided.

BUG=702982
==========

[zakerinasab, 2017-03-20 20:36:51]

zakerinasab@chromium.org changed reviewers:
+ junov@chromium.org

[zakerinasab, 2017-03-20 20:39:12]

CL uploaded. PTAL.

[zakerinasab, 2017-03-21 13:39:23]

Layout test fails hopefully fixed. PTAL.

[Justin Novosad, 2017-03-21 15:20:43]

https://codereview.chromium.org/2759113003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/ImageData.h (right):

https://codereview.chromium.org/2759113003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/ImageData.h:147: bool = false);
To improve readability, please use an enum instead of a bool for this argument. 
Also, would be clearer if you used names that describe the effect of the
argument  Ex:
enum StorageFormatSource {
  kStorageFormatFromColorSettings, 
  kStorageFormatFromBufferType
}

[zakerinasab, 2017-03-21 15:48:14]

New CL uploaded. PTAL.

https://codereview.chromium.org/2759113003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/ImageData.h (right):

https://codereview.chromium.org/2759113003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/ImageData.h:147: bool = false);
On 2017/03/21 15:20:43, Justin Novosad wrote:
> To improve readability, please use an enum instead of a bool for this
argument. 
> Also, would be clearer if you used names that describe the effect of the
> argument  Ex:
> enum StorageFormatSource {
>   kStorageFormatFromColorSettings, 
>   kStorageFormatFromBufferType
> }

Done.

[Justin Novosad, 2017-03-21 17:50:48]

lgtm

[zakerinasab, 2017-03-21 18:05:54]

The CQ bit was checked by zakerinasab@chromium.org

[commit-bot: I haz the power, 2017-03-21 18:06:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 19:19:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490119554004340,
"parent_rev": "b1fa5d65d331f0b1f06a771e9cad826ee8a40544", "commit_rev":
"03666b25531fd69b88fc2d6685d639cd893a79f0"}

[commit-bot: I haz the power, 2017-03-21 19:20:31]

Description was changed from

==========
Fixing bad casting between DOMTypedArray objects

Fixing bad casting between DOMTypeArray objects by overriding
ImageDataColorSettings.ImageDataStorageFormat when external data array is
provided.

BUG=702982
==========

to

==========
Fixing bad casting between DOMTypedArray objects

Fixing bad casting between DOMTypeArray objects by overriding
ImageDataColorSettings.ImageDataStorageFormat when external data array is
provided.

BUG=702982

Review-Url: https://codereview.chromium.org/2759113003
Cr-Commit-Position: refs/heads/master@{#458504}
Committed:
https://chromium.googlesource.com/chromium/src/+/03666b25531fd69b88fc2d6685d6...
==========

[commit-bot: I haz the power, 2017-03-21 19:20:32]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/03666b25531fd69b88fc2d6685d6...