Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2759113003: Fixing bad casting between DOMTypedArray objects (Closed)

Created:
3 years, 9 months ago by zakerinasab
Modified:
3 years, 9 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing bad casting between DOMTypedArray objects Fixing bad casting between DOMTypeArray objects by overriding ImageDataColorSettings.ImageDataStorageFormat when external data array is provided. BUG=702982 Review-Url: https://codereview.chromium.org/2759113003 Cr-Commit-Position: refs/heads/master@{#458504} Committed: https://chromium.googlesource.com/chromium/src/+/03666b25531fd69b88fc2d6685d639cd893a79f0

Patch Set 1 #

Patch Set 2 : Fixing layout tests fails #

Total comments: 2

Patch Set 3 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -15 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace.html View 1 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageData.h View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/ImageData.cpp View 1 2 3 chunks +27 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
zakerinasab
CL uploaded. PTAL.
3 years, 9 months ago (2017-03-20 20:39:12 UTC) #3
zakerinasab
Layout test fails hopefully fixed. PTAL.
3 years, 9 months ago (2017-03-21 13:39:23 UTC) #4
Justin Novosad
https://codereview.chromium.org/2759113003/diff/20001/third_party/WebKit/Source/core/html/ImageData.h File third_party/WebKit/Source/core/html/ImageData.h (right): https://codereview.chromium.org/2759113003/diff/20001/third_party/WebKit/Source/core/html/ImageData.h#newcode147 third_party/WebKit/Source/core/html/ImageData.h:147: bool = false); To improve readability, please use an ...
3 years, 9 months ago (2017-03-21 15:20:43 UTC) #5
zakerinasab
New CL uploaded. PTAL. https://codereview.chromium.org/2759113003/diff/20001/third_party/WebKit/Source/core/html/ImageData.h File third_party/WebKit/Source/core/html/ImageData.h (right): https://codereview.chromium.org/2759113003/diff/20001/third_party/WebKit/Source/core/html/ImageData.h#newcode147 third_party/WebKit/Source/core/html/ImageData.h:147: bool = false); On 2017/03/21 ...
3 years, 9 months ago (2017-03-21 15:48:14 UTC) #6
Justin Novosad
lgtm
3 years, 9 months ago (2017-03-21 17:50:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759113003/40001
3 years, 9 months ago (2017-03-21 18:06:43 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 19:20:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/03666b25531fd69b88fc2d6685d6...

Powered by Google App Engine
This is Rietveld 408576698