Fixing bad casting between DOMTypedArray objects

third_party/WebKit/Source/core/html/ImageData.h

 /*
  * Copyright (C) 2008, 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 125 matching lines @@
   static bool validateConstructorArguments(const unsigned&,
                                            const IntSize* = nullptr,
                                            const unsigned& = 0,
                                            const unsigned& = 0,
                                            const DOMArrayBufferView* = nullptr,
                                            ExceptionState* = nullptr);
 
  private:
   ImageData(const IntSize&,
             DOMArrayBufferView*,
-            const ImageDataColorSettings* = nullptr);
+            const ImageDataColorSettings* = nullptr,
+            bool = false);

[Justin Novosad, 2017/03/21 15:20:43]

To improve readability, please use an enum instead of a bool for this argument. 
Also, would be clearer if you used names that describe the effect of the
argument  Ex:
enum StorageFormatSource {
  kStorageFormatFromColorSettings, 
  kStorageFormatFromBufferType
}

[zakerinasab, 2017/03/21 15:48:14]

Done.

 
   IntSize m_size;
   ImageDataColorSettings m_colorSettings;
   ImageDataArray m_dataUnion;
   Member<DOMUint8ClampedArray> m_data;
   Member<DOMUint16Array> m_dataU16;
   Member<DOMFloat32Array> m_dataF32;
 
   static DOMArrayBufferView* allocateAndValidateDataArray(
       const unsigned&,
       ImageDataStorageFormat,
       ExceptionState* = nullptr);
 };
 
 }  // namespace blink
 
 #endif  // ImageData_h