Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2759093004: [interpreter] Split out intrinsics generation (Closed)

Created:
3 years, 9 months ago by Jakob Kummerow
Modified:
3 years, 9 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Split out intrinsics generation This frees up the InterpreterAssembler for no longer being linked into the main library. BUG=v8:6055 Review-Url: https://codereview.chromium.org/2759093004 Cr-Commit-Position: refs/heads/master@{#43979} Committed: https://chromium.googlesource.com/v8/v8/+/c8a727dec21e5aa0618d30793cfd68d3dcc77665

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix nit #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -426 lines) Patch
M BUILD.gn View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/interpreter/interpreter-generator.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.h View 1 2 chunks +1 line, -44 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.cc View 2 chunks +1 line, -295 lines 0 comments Download
A src/interpreter/interpreter-intrinsics-generator.h View 1 chunk +29 lines, -0 lines 0 comments Download
A + src/interpreter/interpreter-intrinsics-generator.cc View 11 chunks +94 lines, -81 lines 0 comments Download
M src/v8.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Jakob Kummerow
More mechanical splitting. PTAL.
3 years, 9 months ago (2017-03-20 17:48:39 UTC) #2
rmcilroy
LGTM, thanks. https://codereview.chromium.org/2759093004/diff/1/src/interpreter/interpreter-intrinsics.h File src/interpreter/interpreter-intrinsics.h (right): https://codereview.chromium.org/2759093004/diff/1/src/interpreter/interpreter-intrinsics.h#newcode49 src/interpreter/interpreter-intrinsics.h:49: DISALLOW_COPY_AND_ASSIGN(IntrinsicsHelper); nit - DISALLOW_IMPLICIT_CONSTRUCTORS
3 years, 9 months ago (2017-03-20 18:17:11 UTC) #3
Jakob Kummerow
Thanks, landing. https://codereview.chromium.org/2759093004/diff/1/src/interpreter/interpreter-intrinsics.h File src/interpreter/interpreter-intrinsics.h (right): https://codereview.chromium.org/2759093004/diff/1/src/interpreter/interpreter-intrinsics.h#newcode49 src/interpreter/interpreter-intrinsics.h:49: DISALLOW_COPY_AND_ASSIGN(IntrinsicsHelper); On 2017/03/20 18:17:11, rmcilroy wrote: > ...
3 years, 9 months ago (2017-03-21 11:20:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759093004/40001
3 years, 9 months ago (2017-03-21 11:21:17 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 12:33:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/c8a727dec21e5aa0618d30793cfd68d3dcc...

Powered by Google App Engine
This is Rietveld 408576698