Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/interpreter/interpreter-intrinsics.cc

Issue 2759093004: [interpreter] Split out intrinsics generation (Closed)
Patch Set: rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/interpreter-intrinsics.h ('k') | src/interpreter/interpreter-intrinsics-generator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/interpreter-intrinsics.cc
diff --git a/src/interpreter/interpreter-intrinsics.cc b/src/interpreter/interpreter-intrinsics.cc
index 78de42b634d3e4b0a566031499e1abb239bd4226..1682d59c27af13bbf82e49410275f04b631a0a0b 100644
--- a/src/interpreter/interpreter-intrinsics.cc
+++ b/src/interpreter/interpreter-intrinsics.cc
@@ -4,22 +4,12 @@
#include "src/interpreter/interpreter-intrinsics.h"
-#include "src/code-factory.h"
-#include "src/objects-inl.h"
+#include "src/base/logging.h"
namespace v8 {
namespace internal {
namespace interpreter {
-using compiler::Node;
-
-#define __ assembler_->
-
-IntrinsicsHelper::IntrinsicsHelper(InterpreterAssembler* assembler)
- : isolate_(assembler->isolate()),
- zone_(assembler->zone()),
- assembler_(assembler) {}
-
// static
bool IntrinsicsHelper::IsSupported(Runtime::FunctionId function_id) {
switch (function_id) {
@@ -62,290 +52,6 @@ Runtime::FunctionId IntrinsicsHelper::ToRuntimeId(
}
}
-Node* IntrinsicsHelper::InvokeIntrinsic(Node* function_id, Node* context,
- Node* first_arg_reg, Node* arg_count) {
- InterpreterAssembler::Label abort(assembler_), end(assembler_);
- InterpreterAssembler::Variable result(assembler_,
- MachineRepresentation::kTagged);
-
-#define MAKE_LABEL(name, lower_case, count) \
- InterpreterAssembler::Label lower_case(assembler_);
- INTRINSICS_LIST(MAKE_LABEL)
-#undef MAKE_LABEL
-
-#define LABEL_POINTER(name, lower_case, count) &lower_case,
- InterpreterAssembler::Label* labels[] = {INTRINSICS_LIST(LABEL_POINTER)};
-#undef LABEL_POINTER
-
-#define CASE(name, lower_case, count) \
- static_cast<int32_t>(IntrinsicId::k##name),
- int32_t cases[] = {INTRINSICS_LIST(CASE)};
-#undef CASE
-
- __ Switch(function_id, &abort, cases, labels, arraysize(cases));
-#define HANDLE_CASE(name, lower_case, expected_arg_count) \
- __ Bind(&lower_case); \
- if (FLAG_debug_code && expected_arg_count >= 0) { \
- AbortIfArgCountMismatch(expected_arg_count, arg_count); \
- } \
- result.Bind(name(first_arg_reg, arg_count, context)); \
- __ Goto(&end);
- INTRINSICS_LIST(HANDLE_CASE)
-#undef HANDLE_CASE
-
- __ Bind(&abort);
- {
- __ Abort(BailoutReason::kUnexpectedFunctionIDForInvokeIntrinsic);
- result.Bind(__ UndefinedConstant());
- __ Goto(&end);
- }
-
- __ Bind(&end);
- return result.value();
-}
-
-Node* IntrinsicsHelper::CompareInstanceType(Node* object, int type,
- InstanceTypeCompareMode mode) {
- Node* instance_type = __ LoadInstanceType(object);
-
- if (mode == kInstanceTypeEqual) {
- return __ Word32Equal(instance_type, __ Int32Constant(type));
- } else {
- DCHECK(mode == kInstanceTypeGreaterThanOrEqual);
- return __ Int32GreaterThanOrEqual(instance_type, __ Int32Constant(type));
- }
-}
-
-Node* IntrinsicsHelper::IsInstanceType(Node* input, int type) {
- InterpreterAssembler::Variable return_value(assembler_,
- MachineRepresentation::kTagged);
- // TODO(ishell): Use Select here.
- InterpreterAssembler::Label if_not_smi(assembler_), return_true(assembler_),
- return_false(assembler_), end(assembler_);
- Node* arg = __ LoadRegister(input);
- __ GotoIf(__ TaggedIsSmi(arg), &return_false);
-
- Node* condition = CompareInstanceType(arg, type, kInstanceTypeEqual);
- __ Branch(condition, &return_true, &return_false);
-
- __ Bind(&return_true);
- {
- return_value.Bind(__ BooleanConstant(true));
- __ Goto(&end);
- }
-
- __ Bind(&return_false);
- {
- return_value.Bind(__ BooleanConstant(false));
- __ Goto(&end);
- }
-
- __ Bind(&end);
- return return_value.value();
-}
-
-Node* IntrinsicsHelper::IsJSReceiver(Node* input, Node* arg_count,
- Node* context) {
- // TODO(ishell): Use Select here.
- // TODO(ishell): Use CSA::IsJSReceiverInstanceType here.
- InterpreterAssembler::Variable return_value(assembler_,
- MachineRepresentation::kTagged);
- InterpreterAssembler::Label return_true(assembler_), return_false(assembler_),
- end(assembler_);
-
- Node* arg = __ LoadRegister(input);
- __ GotoIf(__ TaggedIsSmi(arg), &return_false);
-
- STATIC_ASSERT(LAST_TYPE == LAST_JS_RECEIVER_TYPE);
- Node* condition = CompareInstanceType(arg, FIRST_JS_RECEIVER_TYPE,
- kInstanceTypeGreaterThanOrEqual);
- __ Branch(condition, &return_true, &return_false);
-
- __ Bind(&return_true);
- {
- return_value.Bind(__ BooleanConstant(true));
- __ Goto(&end);
- }
-
- __ Bind(&return_false);
- {
- return_value.Bind(__ BooleanConstant(false));
- __ Goto(&end);
- }
-
- __ Bind(&end);
- return return_value.value();
-}
-
-Node* IntrinsicsHelper::IsArray(Node* input, Node* arg_count, Node* context) {
- return IsInstanceType(input, JS_ARRAY_TYPE);
-}
-
-Node* IntrinsicsHelper::IsJSProxy(Node* input, Node* arg_count, Node* context) {
- return IsInstanceType(input, JS_PROXY_TYPE);
-}
-
-Node* IntrinsicsHelper::IsTypedArray(Node* input, Node* arg_count,
- Node* context) {
- return IsInstanceType(input, JS_TYPED_ARRAY_TYPE);
-}
-
-Node* IntrinsicsHelper::IsSmi(Node* input, Node* arg_count, Node* context) {
- // TODO(ishell): Use SelectBooleanConstant here.
- InterpreterAssembler::Variable return_value(assembler_,
- MachineRepresentation::kTagged);
- InterpreterAssembler::Label if_smi(assembler_), if_not_smi(assembler_),
- end(assembler_);
-
- Node* arg = __ LoadRegister(input);
-
- __ Branch(__ TaggedIsSmi(arg), &if_smi, &if_not_smi);
- __ Bind(&if_smi);
- {
- return_value.Bind(__ BooleanConstant(true));
- __ Goto(&end);
- }
-
- __ Bind(&if_not_smi);
- {
- return_value.Bind(__ BooleanConstant(false));
- __ Goto(&end);
- }
-
- __ Bind(&end);
- return return_value.value();
-}
-
-Node* IntrinsicsHelper::IntrinsicAsStubCall(Node* args_reg, Node* context,
- Callable const& callable) {
- int param_count = callable.descriptor().GetParameterCount();
- int input_count = param_count + 2; // +2 for target and context
- Node** args = zone()->NewArray<Node*>(input_count);
- int index = 0;
- args[index++] = __ HeapConstant(callable.code());
- for (int i = 0; i < param_count; i++) {
- args[index++] = __ LoadRegister(args_reg);
- args_reg = __ NextRegister(args_reg);
- }
- args[index++] = context;
- return __ CallStubN(callable.descriptor(), 1, input_count, args);
-}
-
-Node* IntrinsicsHelper::CreateIterResultObject(Node* input, Node* arg_count,
- Node* context) {
- return IntrinsicAsStubCall(input, context,
- CodeFactory::CreateIterResultObject(isolate()));
-}
-
-Node* IntrinsicsHelper::HasProperty(Node* input, Node* arg_count,
- Node* context) {
- return IntrinsicAsStubCall(input, context,
- CodeFactory::HasProperty(isolate()));
-}
-
-Node* IntrinsicsHelper::SubString(Node* input, Node* arg_count, Node* context) {
- return IntrinsicAsStubCall(input, context, CodeFactory::SubString(isolate()));
-}
-
-Node* IntrinsicsHelper::ToString(Node* input, Node* arg_count, Node* context) {
- return IntrinsicAsStubCall(input, context, CodeFactory::ToString(isolate()));
-}
-
-Node* IntrinsicsHelper::ToLength(Node* input, Node* arg_count, Node* context) {
- return IntrinsicAsStubCall(input, context, CodeFactory::ToLength(isolate()));
-}
-
-Node* IntrinsicsHelper::ToInteger(Node* input, Node* arg_count, Node* context) {
- return IntrinsicAsStubCall(input, context, CodeFactory::ToInteger(isolate()));
-}
-
-Node* IntrinsicsHelper::ToNumber(Node* input, Node* arg_count, Node* context) {
- return IntrinsicAsStubCall(input, context, CodeFactory::ToNumber(isolate()));
-}
-
-Node* IntrinsicsHelper::ToObject(Node* input, Node* arg_count, Node* context) {
- return IntrinsicAsStubCall(input, context, CodeFactory::ToObject(isolate()));
-}
-
-Node* IntrinsicsHelper::Call(Node* args_reg, Node* arg_count, Node* context) {
- // First argument register contains the function target.
- Node* function = __ LoadRegister(args_reg);
-
- // Receiver is the second runtime call argument.
- Node* receiver_reg = __ NextRegister(args_reg);
- Node* receiver_arg = __ RegisterLocation(receiver_reg);
-
- // Subtract function and receiver from arg count.
- Node* function_and_receiver_count = __ Int32Constant(2);
- Node* target_args_count = __ Int32Sub(arg_count, function_and_receiver_count);
-
- if (FLAG_debug_code) {
- InterpreterAssembler::Label arg_count_positive(assembler_);
- Node* comparison = __ Int32LessThan(target_args_count, __ Int32Constant(0));
- __ GotoIfNot(comparison, &arg_count_positive);
- __ Abort(kWrongArgumentCountForInvokeIntrinsic);
- __ Goto(&arg_count_positive);
- __ Bind(&arg_count_positive);
- }
-
- Node* result = __ CallJS(function, context, receiver_arg, target_args_count,
- TailCallMode::kDisallow);
- return result;
-}
-
-Node* IntrinsicsHelper::ClassOf(Node* args_reg, Node* arg_count,
- Node* context) {
- Node* value = __ LoadRegister(args_reg);
- return __ ClassOf(value);
-}
-
-Node* IntrinsicsHelper::CreateAsyncFromSyncIterator(Node* args_reg,
- Node* arg_count,
- Node* context) {
- InterpreterAssembler::Label not_receiver(
- assembler_, InterpreterAssembler::Label::kDeferred);
- InterpreterAssembler::Label done(assembler_);
- InterpreterAssembler::Variable return_value(assembler_,
- MachineRepresentation::kTagged);
-
- Node* sync_iterator = __ LoadRegister(args_reg);
-
- __ GotoIf(__ TaggedIsSmi(sync_iterator), &not_receiver);
- __ GotoIfNot(__ IsJSReceiver(sync_iterator), &not_receiver);
-
- Node* const native_context = __ LoadNativeContext(context);
- Node* const map = __ LoadContextElement(
- native_context, Context::ASYNC_FROM_SYNC_ITERATOR_MAP_INDEX);
- Node* const iterator = __ AllocateJSObjectFromMap(map);
-
- __ StoreObjectFieldNoWriteBarrier(
- iterator, JSAsyncFromSyncIterator::kSyncIteratorOffset, sync_iterator);
-
- return_value.Bind(iterator);
- __ Goto(&done);
-
- __ Bind(&not_receiver);
- {
- return_value.Bind(
- __ CallRuntime(Runtime::kThrowSymbolIteratorInvalid, context));
-
- // Unreachable due to the Throw in runtime call.
- __ Goto(&done);
- }
-
- __ Bind(&done);
- return return_value.value();
-}
-
-void IntrinsicsHelper::AbortIfArgCountMismatch(int expected, Node* actual) {
- InterpreterAssembler::Label match(assembler_);
- Node* comparison = __ Word32Equal(actual, __ Int32Constant(expected));
- __ GotoIf(comparison, &match);
- __ Abort(kWrongArgumentCountForInvokeIntrinsic);
- __ Goto(&match);
- __ Bind(&match);
-}
-
} // namespace interpreter
} // namespace internal
} // namespace v8
« no previous file with comments | « src/interpreter/interpreter-intrinsics.h ('k') | src/interpreter/interpreter-intrinsics-generator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698