Remove most of Widget (FrameViewBase) class from HTMLPlugInElement.

Remove most of Widget (FrameViewBase) class from HTMLPlugInElement.

* Replace references to FrameViewBase with PluginView subclass.
* Create stub setPlugin/releasePlugin/ownedPlugin methods which redirect to
HTMLFrameOwnerElement *Widget* methods for now.
* Next step will be to remove the inheritance from PluginView to
FrameViewBase and provide implementation of the new stub methods.

BUG=637460
Review-Url: https://codereview.chromium.org/2759063002
Cr-Commit-Position: refs/heads/master@{#458571}
Committed: https://chromium.googlesource.com/chromium/src/+/0c51a5fdf9f27c4758e4ae2b2b54dff2b8890181

[joelhockey, 2017-03-20 02:39:45]

Description was changed from

==========
Remove Widget (FrameViewBase) class from HTMLPlugInElement.
Replace FrameViewBase with PluginView subclass.
Next step will be to remove the inheritance from PluginView to
FrameViewBase.

BUG=637460
==========

to

==========
Remove Widget (FrameViewBase) class from HTMLPlugInElement.

* Replace references to FrameViewBase with PluginView subclass.
* Create stub setPlugin/releasePlugin/ownedPlugin methods on
HTMLFrameOwnerElement which redirect to *Widget* methods for now.
* Next step will be to remove the inheritance from PluginView to
FrameViewBase and provide implementation of the new stub
HTMLFrameOwnerElement methods.

BUG=637460
==========

[joelhockey, 2017-03-20 02:46:43]

Description was changed from

==========
Remove Widget (FrameViewBase) class from HTMLPlugInElement.

* Replace references to FrameViewBase with PluginView subclass.
* Create stub setPlugin/releasePlugin/ownedPlugin methods on
HTMLFrameOwnerElement which redirect to *Widget* methods for now.
* Next step will be to remove the inheritance from PluginView to
FrameViewBase and provide implementation of the new stub
HTMLFrameOwnerElement methods.

BUG=637460
==========

to

==========
Remove most of Widget (FrameViewBase) class from HTMLPlugInElement.

* Replace references to FrameViewBase with PluginView subclass.
* Create stub setPlugin/releasePlugin/ownedPlugin methods on
HTMLFrameOwnerElement which redirect to *Widget* methods for now.
* Next step will be to remove the inheritance from PluginView to
FrameViewBase and provide implementation of the new stub
HTMLFrameOwnerElement methods.

BUG=637460
==========

[joelhockey, 2017-03-20 02:51:18]

The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 02:51:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joelhockey, 2017-03-20 02:54:05]

joelhockey@chromium.org changed reviewers:
+ slangley@chromium.org

[slangley, 2017-03-20 03:05:43]

lgtm

https://codereview.chromium.org/2759063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h (right):

https://codereview.chromium.org/2759063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h:63: void
setWidget(FrameViewBase*);
Do we need a TODO here to remove these in followup CL?

[haraken, 2017-03-20 03:06:34]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2017-03-20 03:06:35]

LGTM

This looks like a good way forward.

https://codereview.chromium.org/2759063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp (right):

https://codereview.chromium.org/2759063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp:296:
DCHECK(!m_widget || m_widget->isPluginView());

I'd use CHECK until we completely remove FrameViewBase (to catch some unexpected
programming error).

https://codereview.chromium.org/2759063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp:301:
DCHECK(!m_widget || m_widget->isPluginView());

Ditto.

https://codereview.chromium.org/2759063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h (right):

https://codereview.chromium.org/2759063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h:63: void
setWidget(FrameViewBase*);

Add:

// TODO(joelhockey): Remove these methods once PluginView stops inheriting from
FrameViewBase.

https://codereview.chromium.org/2759063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp (left):

https://codereview.chromium.org/2759063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp:108:
m_persistedPluginWidget->isRemoteFrameView());

Just to confirm: Was this code path not reachable?

[commit-bot: I haz the power, 2017-03-20 03:39:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 03:39:37]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[joelhockey, 2017-03-20 03:54:29]

https://codereview.chromium.org/2759063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp (right):

https://codereview.chromium.org/2759063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp:296:
DCHECK(!m_widget || m_widget->isPluginView());
On 2017/03/20 at 03:06:35, haraken wrote:
> I'd use CHECK until we completely remove FrameViewBase (to catch some
unexpected programming error).

I have changed to use toPluginViewOrDie which does the CHECK.

I have moved these 3 methods to HTMLPlugInElement.

https://codereview.chromium.org/2759063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp:301:
DCHECK(!m_widget || m_widget->isPluginView());
On 2017/03/20 at 03:06:35, haraken wrote:
> Ditto.

Done

https://codereview.chromium.org/2759063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h (right):

https://codereview.chromium.org/2759063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h:63: void
setWidget(FrameViewBase*);
On 2017/03/20 at 03:05:42, slangley wrote:
> Do we need a TODO here to remove these in followup CL?

This method is and will still be called for FrameView.  It will likely change
name to setFrameView or setFrame.  I don't think there is a need for TODO right
now.  If I was going to start putting them in, they would be in a lot of places.

https://codereview.chromium.org/2759063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp (left):

https://codereview.chromium.org/2759063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp:108:
m_persistedPluginWidget->isRemoteFrameView());
On 2017/03/20 at 03:06:35, haraken wrote:
> Just to confirm: Was this code path not reachable?

Yes, the code path has never been reachable, and by changing the type from
FrameViewBase to PluginView, this becomes clearly evident.

Type of m_persistedPlugin has been changed from FrameViewBase to PluginView, so
check on old line 103 for m_persistedPlugin->isPluginView is always true.

[joelhockey, 2017-03-20 03:54:40]

The CQ bit was checked by joelhockey@chromium.org

[commit-bot: I haz the power, 2017-03-20 03:54:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joelhockey, 2017-03-20 04:11:00]

The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 04:11:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 05:02:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 05:02:10]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[joelhockey, 2017-03-20 07:05:23]

The CQ bit was checked by joelhockey@chromium.org

[joelhockey, 2017-03-20 07:05:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, slangley@chromium.org
Link to the patchset: https://codereview.chromium.org/2759063002/#ps40001
(title: "null check for ownedPlugin()")

[commit-bot: I haz the power, 2017-03-20 07:05:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 07:53:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 07:53:15]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[joelhockey, 2017-03-21 06:48:07]

The CQ bit was checked by joelhockey@chromium.org

[joelhockey, 2017-03-21 06:48:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, slangley@chromium.org
Link to the patchset: https://codereview.chromium.org/2759063002/#ps60001
(title: "y")

[commit-bot: I haz the power, 2017-03-21 06:48:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-03-21 07:12:49]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2017-03-21 07:12:51]

(adding myself as a reviewer so I remember to look tomorrow morning in PST AM)

[commit-bot: I haz the power, 2017-03-21 08:37:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 08:37:08]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[joelhockey, 2017-03-21 10:04:16]

The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 10:04:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joelhockey, 2017-03-21 10:24:41]

The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 10:24:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 12:10:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 12:10:01]

Dry run: This issue passed the CQ dry run.

[joelhockey, 2017-03-21 21:47:25]

On 2017/03/21 at 07:12:51, dcheng wrote:
> (adding myself as a reviewer so I remember to look tomorrow morning in PST AM)

Daniel, I'm going to go ahead and submit.  If you review this and have major
objections, I can always rollback, or I can do follow up CLs with any
suggestions you have.

[joelhockey, 2017-03-21 21:47:33]

The CQ bit was checked by joelhockey@chromium.org

[joelhockey, 2017-03-21 21:47:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, slangley@chromium.org
Link to the patchset: https://codereview.chromium.org/2759063002/#ps140001
(title: "Fix shouldAccelerate")

[commit-bot: I haz the power, 2017-03-21 21:48:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joelhockey, 2017-03-21 21:49:15]

Description was changed from

==========
Remove most of Widget (FrameViewBase) class from HTMLPlugInElement.

* Replace references to FrameViewBase with PluginView subclass.
* Create stub setPlugin/releasePlugin/ownedPlugin methods on
HTMLFrameOwnerElement which redirect to *Widget* methods for now.
* Next step will be to remove the inheritance from PluginView to
FrameViewBase and provide implementation of the new stub
HTMLFrameOwnerElement methods.

BUG=637460
==========

to

==========
Remove most of Widget (FrameViewBase) class from HTMLPlugInElement.

* Replace references to FrameViewBase with PluginView subclass.
* Create stub setPlugin/releasePlugin/ownedPlugin methods which redirect to
HTMLFrameOwnerElement *Widget* methods for now.
* Next step will be to remove the inheritance from PluginView to
FrameViewBase and provide implementation of the new stub methods.

BUG=637460
==========

[dcheng, 2017-03-21 21:56:01]

No objections from me. lgtm

[commit-bot: I haz the power, 2017-03-21 21:59:47]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1490132853269100,
"parent_rev": "2665368b5aeaa70dbc5d6f270a202e9b4c98d6b6", "commit_rev":
"0c51a5fdf9f27c4758e4ae2b2b54dff2b8890181"}

[commit-bot: I haz the power, 2017-03-21 22:00:34]

Description was changed from

==========
Remove most of Widget (FrameViewBase) class from HTMLPlugInElement.

* Replace references to FrameViewBase with PluginView subclass.
* Create stub setPlugin/releasePlugin/ownedPlugin methods which redirect to
HTMLFrameOwnerElement *Widget* methods for now.
* Next step will be to remove the inheritance from PluginView to
FrameViewBase and provide implementation of the new stub methods.

BUG=637460
==========

to

==========
Remove most of Widget (FrameViewBase) class from HTMLPlugInElement.

* Replace references to FrameViewBase with PluginView subclass.
* Create stub setPlugin/releasePlugin/ownedPlugin methods which redirect to
HTMLFrameOwnerElement *Widget* methods for now.
* Next step will be to remove the inheritance from PluginView to
FrameViewBase and provide implementation of the new stub methods.

BUG=637460

Review-Url: https://codereview.chromium.org/2759063002
Cr-Commit-Position: refs/heads/master@{#458571}
Committed:
https://chromium.googlesource.com/chromium/src/+/0c51a5fdf9f27c4758e4ae2b2b54...
==========

[commit-bot: I haz the power, 2017-03-21 22:00:36]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/0c51a5fdf9f27c4758e4ae2b2b54...