Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

Issue 2759063002: Remove most of Widget (FrameViewBase) class from HTMLPlugInElement. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 18 matching lines...) Expand all
29 #include "platform/scroll/ScrollTypes.h" 29 #include "platform/scroll/ScrollTypes.h"
30 #include "platform/weborigin/SecurityPolicy.h" 30 #include "platform/weborigin/SecurityPolicy.h"
31 #include "wtf/HashCountedSet.h" 31 #include "wtf/HashCountedSet.h"
32 32
33 namespace blink { 33 namespace blink {
34 34
35 class ExceptionState; 35 class ExceptionState;
36 class Frame; 36 class Frame;
37 class FrameViewBase; 37 class FrameViewBase;
38 class LayoutPart; 38 class LayoutPart;
39 class PluginView;
39 40
40 class CORE_EXPORT HTMLFrameOwnerElement : public HTMLElement, 41 class CORE_EXPORT HTMLFrameOwnerElement : public HTMLElement,
41 public FrameOwner { 42 public FrameOwner {
42 USING_GARBAGE_COLLECTED_MIXIN(HTMLFrameOwnerElement); 43 USING_GARBAGE_COLLECTED_MIXIN(HTMLFrameOwnerElement);
43 44
44 public: 45 public:
45 ~HTMLFrameOwnerElement() override; 46 ~HTMLFrameOwnerElement() override;
46 47
47 DOMWindow* contentWindow() const; 48 DOMWindow* contentWindow() const;
48 Document* contentDocument() const; 49 Document* contentDocument() const;
49 50
50 virtual void disconnectContentFrame(); 51 virtual void disconnectContentFrame();
51 52
52 // Most subclasses use LayoutPart (either LayoutEmbeddedObject or 53 // Most subclasses use LayoutPart (either LayoutEmbeddedObject or
53 // LayoutIFrame) except for HTMLObjectElement and HTMLEmbedElement which may 54 // LayoutIFrame) except for HTMLObjectElement and HTMLEmbedElement which may
54 // return any LayoutObject when using fallback content. 55 // return any LayoutObject when using fallback content.
55 LayoutPart* layoutPart() const; 56 LayoutPart* layoutPart() const;
56 57
57 Document* getSVGDocument(ExceptionState&) const; 58 Document* getSVGDocument(ExceptionState&) const;
58 59
59 virtual bool loadedNonEmptyDocument() const { return false; } 60 virtual bool loadedNonEmptyDocument() const { return false; }
60 virtual void didLoadNonEmptyDocument() {} 61 virtual void didLoadNonEmptyDocument() {}
61 62
62 void setWidget(FrameViewBase*); 63 void setWidget(FrameViewBase*);
slangley 2017/03/20 03:05:42 Do we need a TODO here to remove these in followup
haraken 2017/03/20 03:06:35 Add: // TODO(joelhockey): Remove these methods on
joelhockey 2017/03/20 03:54:29 This method is and will still be called for FrameV
63 FrameViewBase* releaseWidget(); 64 FrameViewBase* releaseWidget();
64 FrameViewBase* ownedWidget() const; 65 FrameViewBase* ownedWidget() const;
66 void setPlugin(PluginView*);
67 PluginView* releasePlugin();
68 PluginView* ownedPlugin() const;
65 69
66 class UpdateSuspendScope { 70 class UpdateSuspendScope {
67 STACK_ALLOCATED(); 71 STACK_ALLOCATED();
68 72
69 public: 73 public:
70 UpdateSuspendScope(); 74 UpdateSuspendScope();
71 ~UpdateSuspendScope(); 75 ~UpdateSuspendScope();
72 76
73 private: 77 private:
74 void performDeferredWidgetTreeOperations(); 78 void performDeferredWidgetTreeOperations();
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 169
166 DEFINE_TYPE_CASTS(HTMLFrameOwnerElement, 170 DEFINE_TYPE_CASTS(HTMLFrameOwnerElement,
167 FrameOwner, 171 FrameOwner,
168 owner, 172 owner,
169 owner->isLocal(), 173 owner->isLocal(),
170 owner.isLocal()); 174 owner.isLocal());
171 175
172 } // namespace blink 176 } // namespace blink
173 177
174 #endif // HTMLFrameOwnerElement_h 178 #endif // HTMLFrameOwnerElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698