Move the functions which block, resume and cancel requests for a frame route id out of ResourceDisp…

Move the functions which block, resume and cancel requests for a frame route id out of ResourceDispatcherHost

The functions BlockRequestsForFrameFromUI,  ResumeBlockedRequestsForFrameFromUI and CancelBlockedRequestsForFrameFromUI
have been moved to the RenderFrameHost class. The FromUI suffix has been dropped. The implementations of these functions
live in render_frame_host_impl.cc. I also moved/renamed the helpers like NotifyForEachFrameFromUI, etc to render_frame_host_impl.cc

The remaining reference to RFH/FTN in RDHI is in the LogResourceRequestTimeOnUI() function. Will address that in a subsequent patchset.

This is part of the changes to make the content/browser/loader folder not depend on extraneous content, which will facilitate
this code becoming part of the network service.

BUG=598073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2758993002
Cr-Commit-Position: refs/heads/master@{#458567}
Committed: https://chromium.googlesource.com/chromium/src/+/a0a1b3df67b6a958b8dd7007cc8edcae18a4d9bb

[ananta, 2017-03-18 00:49:48]

Description was changed from

==========
Move the functions which block, resume and cancel requests for a frame route id
out of ResourceDispatcherHost

The functions BlockRequestsForFrameFromUI,  ResumeBlockedRequestsForFrameFromUI
and CancelBlockedRequestsForFrameFromUI
have been moved to the RenderFrameHost class. The FromUI suffix has been
dropped. The implementations of these functions
live in render_frame_host_impl.cc. I also moved/renamed the helpers like
NotifyForEachFrameFromUI, etc to render_frame_host_impl.cc

The remaining reference to RFH/FTN in RDHI is in the
LogResourceRequestTimeOnUI() function. Will address that in a subsequent
patchset.

This is part of the changes to make the content/browser/loader folder not depend
on extraneous content, which will facilitate
this code becoming part of the network service.

BUG=598073
==========

to

==========
Move the functions which block, resume and cancel requests for a frame route id
out of ResourceDispatcherHost

The functions BlockRequestsForFrameFromUI,  ResumeBlockedRequestsForFrameFromUI
and CancelBlockedRequestsForFrameFromUI
have been moved to the RenderFrameHost class. The FromUI suffix has been
dropped. The implementations of these functions
live in render_frame_host_impl.cc. I also moved/renamed the helpers like
NotifyForEachFrameFromUI, etc to render_frame_host_impl.cc

The remaining reference to RFH/FTN in RDHI is in the
LogResourceRequestTimeOnUI() function. Will address that in a subsequent
patchset.

This is part of the changes to make the content/browser/loader folder not depend
on extraneous content, which will facilitate
this code becoming part of the network service.

BUG=598073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[ananta, 2017-03-18 00:52:21]

ananta@chromium.org changed reviewers:
+ jam@chromium.org

[ananta, 2017-03-18 00:52:21]

Please see if this approach is reasonable. Thanks

[ananta, 2017-03-18 00:52:36]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-18 00:53:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 01:04:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 01:04:37]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ananta, 2017-03-18 01:30:43]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-18 01:31:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 02:06:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 02:06:44]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[ananta, 2017-03-18 02:25:59]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-18 02:26:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 03:20:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 03:20:17]

Dry run: This issue passed the CQ dry run.

[jam, 2017-03-20 21:56:09]

https://codereview.chromium.org/2758993002/diff/40001/content/public/browser/...
File content/public/browser/render_frame_host.h (right):

https://codereview.chromium.org/2758993002/diff/40001/content/public/browser/...
content/public/browser/render_frame_host.h:64: static void
BlockRequestsForFrame(RenderFrameHost* root_frame_host);
why are these static instead of just methods?

https://codereview.chromium.org/2758993002/diff/40001/content/public/browser/...
content/public/browser/render_frame_host.h:71: static void
CancelBlockedRequestsForFrame(RenderFrameHost* root_frame_host);
this is only called from inside content, so just put it on RenderFrameHostImpl
per https://www.chromium.org/developers/content-module/content-api

[ananta, 2017-03-20 23:03:14]

https://codereview.chromium.org/2758993002/diff/40001/content/public/browser/...
File content/public/browser/render_frame_host.h (right):

https://codereview.chromium.org/2758993002/diff/40001/content/public/browser/...
content/public/browser/render_frame_host.h:64: static void
BlockRequestsForFrame(RenderFrameHost* root_frame_host);
On 2017/03/20 21:56:09, jam wrote:
> why are these static instead of just methods?

Thanks done

https://codereview.chromium.org/2758993002/diff/40001/content/public/browser/...
content/public/browser/render_frame_host.h:71: static void
CancelBlockedRequestsForFrame(RenderFrameHost* root_frame_host);
On 2017/03/20 21:56:09, jam wrote:
> this is only called from inside content, so just put it on RenderFrameHostImpl
> per https://www.chromium.org/developers/content-module/content-api

Done.

[ananta, 2017-03-20 23:06:34]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 23:07:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 23:10:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 23:10:43]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[ananta, 2017-03-21 00:09:32]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 00:10:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 01:47:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 01:47:25]

Dry run: This issue passed the CQ dry run.

[jam, 2017-03-21 20:31:29]

lgtm

[ananta, 2017-03-21 21:43:40]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2017-03-21 21:44:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 21:53:00]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490132620212010,
"parent_rev": "08e333dbc8949a69fc48129055683477017bf5d8", "commit_rev":
"a0a1b3df67b6a958b8dd7007cc8edcae18a4d9bb"}

[commit-bot: I haz the power, 2017-03-21 21:53:52]

Description was changed from

==========
Move the functions which block, resume and cancel requests for a frame route id
out of ResourceDispatcherHost

The functions BlockRequestsForFrameFromUI,  ResumeBlockedRequestsForFrameFromUI
and CancelBlockedRequestsForFrameFromUI
have been moved to the RenderFrameHost class. The FromUI suffix has been
dropped. The implementations of these functions
live in render_frame_host_impl.cc. I also moved/renamed the helpers like
NotifyForEachFrameFromUI, etc to render_frame_host_impl.cc

The remaining reference to RFH/FTN in RDHI is in the
LogResourceRequestTimeOnUI() function. Will address that in a subsequent
patchset.

This is part of the changes to make the content/browser/loader folder not depend
on extraneous content, which will facilitate
this code becoming part of the network service.

BUG=598073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Move the functions which block, resume and cancel requests for a frame route id
out of ResourceDispatcherHost

The functions BlockRequestsForFrameFromUI,  ResumeBlockedRequestsForFrameFromUI
and CancelBlockedRequestsForFrameFromUI
have been moved to the RenderFrameHost class. The FromUI suffix has been
dropped. The implementations of these functions
live in render_frame_host_impl.cc. I also moved/renamed the helpers like
NotifyForEachFrameFromUI, etc to render_frame_host_impl.cc

The remaining reference to RFH/FTN in RDHI is in the
LogResourceRequestTimeOnUI() function. Will address that in a subsequent
patchset.

This is part of the changes to make the content/browser/loader folder not depend
on extraneous content, which will facilitate
this code becoming part of the network service.

BUG=598073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2758993002
Cr-Commit-Position: refs/heads/master@{#458567}
Committed:
https://chromium.googlesource.com/chromium/src/+/a0a1b3df67b6a958b8dd7007cc8e...
==========

[commit-bot: I haz the power, 2017-03-21 21:53:53]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/a0a1b3df67b6a958b8dd7007cc8e...