Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: content/public/browser/render_frame_host.h

Issue 2758993002: Move the functions which block, resume and cancel requests for a frame route id out of ResourceDisp… (Closed)
Patch Set: Remove DCHECK for RDHI on the same lines as the old code Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/public/browser/BUILD.gn ('k') | content/public/browser/resource_dispatcher_host.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_FRAME_HOST_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_FRAME_HOST_H_
6 #define CONTENT_PUBLIC_BROWSER_RENDER_FRAME_HOST_H_ 6 #define CONTENT_PUBLIC_BROWSER_RENDER_FRAME_HOST_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback_forward.h" 10 #include "base/callback_forward.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 #if defined(OS_ANDROID) 52 #if defined(OS_ANDROID)
53 // Globally allows for injecting JavaScript into the main world. This feature 53 // Globally allows for injecting JavaScript into the main world. This feature
54 // is present only to support Android WebView and must not be used in other 54 // is present only to support Android WebView and must not be used in other
55 // configurations. 55 // configurations.
56 static void AllowInjectingJavaScriptForAndroidWebView(); 56 static void AllowInjectingJavaScriptForAndroidWebView();
57 #endif 57 #endif
58 58
59 // Returns a RenderFrameHost given its accessibility tree ID. 59 // Returns a RenderFrameHost given its accessibility tree ID.
60 static RenderFrameHost* FromAXTreeID(int ax_tree_id); 60 static RenderFrameHost* FromAXTreeID(int ax_tree_id);
61 61
62 // Causes all new requests for the root RenderFrameHost and its children to be
63 // blocked (not being started) until ResumeBlockedRequestsForFrame is called.
64 static void BlockRequestsForFrame(RenderFrameHost* root_frame_host);
jam 2017/03/20 21:56:09 why are these static instead of just methods?
ananta 2017/03/20 23:03:14 Thanks done
65
66 // Resumes any blocked request for the specified root RenderFrameHost and
67 // child frame hosts.
68 static void ResumeBlockedRequestsForFrame(RenderFrameHost* root_frame_host);
69
70 // Cancels any blocked request for the frame and its subframes.
71 static void CancelBlockedRequestsForFrame(RenderFrameHost* root_frame_host);
jam 2017/03/20 21:56:09 this is only called from inside content, so just p
ananta 2017/03/20 23:03:14 Done.
72
62 ~RenderFrameHost() override {} 73 ~RenderFrameHost() override {}
63 74
64 // Returns the route id for this frame. 75 // Returns the route id for this frame.
65 virtual int GetRoutingID() = 0; 76 virtual int GetRoutingID() = 0;
66 77
67 // Returns the accessibility tree ID for this RenderFrameHost. 78 // Returns the accessibility tree ID for this RenderFrameHost.
68 virtual int GetAXTreeID() = 0; 79 virtual int GetAXTreeID() = 0;
69 80
70 // Returns the SiteInstance grouping all RenderFrameHosts that have script 81 // Returns the SiteInstance grouping all RenderFrameHosts that have script
71 // access to this RenderFrameHost, and must therefore live in the same 82 // access to this RenderFrameHost, and must therefore live in the same
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 237
227 private: 238 private:
228 // This interface should only be implemented inside content. 239 // This interface should only be implemented inside content.
229 friend class RenderFrameHostImpl; 240 friend class RenderFrameHostImpl;
230 RenderFrameHost() {} 241 RenderFrameHost() {}
231 }; 242 };
232 243
233 } // namespace content 244 } // namespace content
234 245
235 #endif // CONTENT_PUBLIC_BROWSER_RENDER_FRAME_HOST_H_ 246 #endif // CONTENT_PUBLIC_BROWSER_RENDER_FRAME_HOST_H_
OLDNEW
« no previous file with comments | « content/public/browser/BUILD.gn ('k') | content/public/browser/resource_dispatcher_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698