Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 2758813002: Fix struct traits test deps and target visibility. (Closed)

Created:
8 months, 1 week ago by msw
Modified:
8 months, 1 week ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix struct traits test deps and target visibility. Yuzhu exported mojom::Foo::Deserialize() for component builds: https://codereview.chromium.org/2754003005/ This removes symptomatic extra deps and visibility. BUG=702397 TEST=ash_unittests still builds and links. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2758813002 Cr-Commit-Position: refs/heads/master@{#457820} Committed: https://chromium.googlesource.com/chromium/src/+/00d67ef0786f6a28b6557e6224ddce2104ce8207

Patch Set 1 #

Messages

Total messages: 11 (7 generated)
msw
Hey James, please take a look; thanks!
8 months, 1 week ago (2017-03-17 16:15:02 UTC) #1
James Cook
lgtm
8 months, 1 week ago (2017-03-17 17:25:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758813002/1
8 months, 1 week ago (2017-03-17 18:12:22 UTC) #8
commit-bot: I haz the power
8 months, 1 week ago (2017-03-17 18:25:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/00d67ef0786f6a28b6557e6224dd...

Powered by Google App Engine
This is Rietveld efc10ee0f