Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2754003005: Mojo C++ Bindings: fix mojom::Foo::Deserialize() for component build. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by yzshen1
Modified:
2 months, 1 week ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ Bindings: fix mojom::Foo::Deserialize() for component build. Without this fix, if the mojom target containing mojom::Foo is linked into a component, mojom::Foo::Deserialize() doesn't work outside of that component. The reason is that the method calls mojom::Foo_Data::Valiate() which is not exported. BUG=702397 Review-Url: https://codereview.chromium.org/2754003005 Cr-Commit-Position: refs/heads/master@{#457791} Committed: https://chromium.googlesource.com/chromium/src/+/e9919293913d03d2169f99c882bae1569902ea7e

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -9 lines) Patch
M mojo/public/cpp/bindings/lib/serialization.h View 2 chunks +5 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/struct_unittest.cc View 6 chunks +16 lines, -5 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/BUILD.gn View 1 1 chunk +25 lines, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/test_export2.mojom View 1 chunk +10 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl View 2 chunks +5 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_definition.tmpl View 1 chunk +6 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 16 (12 generated)
yzshen1
Hi, Ken. Please take a look. Thanks! I think eventually we need to change the ...
2 months, 1 week ago (2017-03-17 00:42:51 UTC) #4
Ken Rockot(use gerrit already)
lgtm
2 months, 1 week ago (2017-03-17 15:56:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754003005/20001
2 months, 1 week ago (2017-03-17 16:12:14 UTC) #13
commit-bot: I haz the power
2 months, 1 week ago (2017-03-17 16:31:02 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e9919293913d03d2169f99c882ba...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06