Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2758803003: Make X509Certificate creation fail if X509Certificate::Initialize fails. (Closed)

Created:
3 years, 9 months ago by mattm
Modified:
3 years, 8 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, mac-reviews_chromium.org, ios-reviews_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make X509Certificate creation fail if X509Certificate::Initialize fails. BUG=671420 Review-Url: https://codereview.chromium.org/2758803003 Cr-Commit-Position: refs/heads/master@{#460535} Committed: https://chromium.googlesource.com/chromium/src/+/1c59eda4e5a4c7427f355ed752e94f43561604a3

Patch Set 1 : . #

Patch Set 2 : rebase on updated 2760723002 #

Patch Set 3 : rebase #

Patch Set 4 : footest #

Patch Set 5 : test updates #

Patch Set 6 : test updatess 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -91 lines) Patch
M net/cert/x509_certificate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/cert/x509_certificate.cc View 1 2 2 chunks +11 lines, -2 lines 0 comments Download
M net/cert/x509_certificate_ios.cc View 1 2 3 chunks +27 lines, -23 lines 0 comments Download
M net/cert/x509_certificate_mac.cc View 1 2 5 chunks +24 lines, -18 lines 0 comments Download
M net/cert/x509_certificate_nss.cc View 1 2 1 chunk +8 lines, -7 lines 0 comments Download
M net/cert/x509_certificate_openssl.cc View 1 2 3 chunks +25 lines, -21 lines 0 comments Download
M net/cert/x509_certificate_unittest.cc View 1 2 3 4 2 chunks +7 lines, -2 lines 0 comments Download
M net/cert/x509_certificate_win.cc View 1 2 2 chunks +9 lines, -5 lines 0 comments Download
M net/cert/x509_util_nss.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M net/cert/x509_util_nss.cc View 1 2 3 chunks +8 lines, -4 lines 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 1 2 3 4 5 3 chunks +11 lines, -2 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server_unittest.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 35 (26 generated)
mattm
I'm a little bit worried that changing the behavior of the existing ones might end ...
3 years, 9 months ago (2017-03-17 22:41:13 UTC) #5
Ryan Sleevi
This LGTM as is, but I'm not sure I understood your question?
3 years, 9 months ago (2017-03-17 22:44:51 UTC) #6
mattm
On 2017/03/17 22:44:51, Ryan Sleevi wrote: > This LGTM as is, but I'm not sure ...
3 years, 9 months ago (2017-03-17 23:03:10 UTC) #9
mattm
Had to update a few unittests, if you want to look again.
3 years, 9 months ago (2017-03-28 00:32:01 UTC) #23
mattm
On 2017/03/28 00:32:01, mattm wrote: > Had to update a few unittests, if you want ...
3 years, 8 months ago (2017-03-29 01:06:07 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758803003/120001
3 years, 8 months ago (2017-03-29 01:06:59 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/410348) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 8 months ago (2017-03-29 03:05:23 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758803003/120001
3 years, 8 months ago (2017-03-29 20:04:20 UTC) #32
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 21:05:43 UTC) #35
Message was sent while issue was closed.
Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/1c59eda4e5a4c7427f355ed752e9...

Powered by Google App Engine
This is Rietveld 408576698