Make X509Certificate creation fail if X509Certificate::Initialize fails.

net/cert/x509_certificate_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/x509_certificate.h"
 
 #include <memory>
 
 #include "base/logging.h"
 #include "base/memory/free_deleter.h"
@@ skipping 115 matching lines @@
     BOOL rb = CertCompareCertificateName(
         X509_ASN_ENCODING | PKCS_7_ASN_ENCODING, &issuer_blob, name_blob);
     if (rb)
       return true;
   }
   return false;
 }
 
 }  // namespace
 
-void X509Certificate::Initialize() {
+bool X509Certificate::Initialize() {
   DCHECK(cert_handle_);
-  subject_.ParseDistinguishedName(cert_handle_->pCertInfo->Subject.pbData,
-                                  cert_handle_->pCertInfo->Subject.cbData);
-  issuer_.ParseDistinguishedName(cert_handle_->pCertInfo->Issuer.pbData,
-                                 cert_handle_->pCertInfo->Issuer.cbData);
+  if (!subject_.ParseDistinguishedName(
+          cert_handle_->pCertInfo->Subject.pbData,
+          cert_handle_->pCertInfo->Subject.cbData) ||
+      !issuer_.ParseDistinguishedName(cert_handle_->pCertInfo->Issuer.pbData,
+                                      cert_handle_->pCertInfo->Issuer.cbData))
+    return false;
 
   valid_start_ = Time::FromFileTime(cert_handle_->pCertInfo->NotBefore);
   valid_expiry_ = Time::FromFileTime(cert_handle_->pCertInfo->NotAfter);
 
   const CRYPT_INTEGER_BLOB* serial = &cert_handle_->pCertInfo->SerialNumber;
   std::unique_ptr<uint8_t[]> serial_bytes(new uint8_t[serial->cbData]);
   for (unsigned i = 0; i < serial->cbData; i++)
     serial_bytes[i] = serial->pbData[serial->cbData - i - 1];
   serial_number_ = std::string(
       reinterpret_cast<char*>(serial_bytes.get()), serial->cbData);
+
+  return true;
 }
 
 bool X509Certificate::GetSubjectAltName(
     std::vector<std::string>* dns_names,
     std::vector<std::string>* ip_addrs) const {
   if (dns_names)
     dns_names->clear();
   if (ip_addrs)
     ip_addrs->clear();
 
@@ skipping 298 matching lines @@
       CRYPT_VERIFY_CERT_SIGN_ISSUER_CERT,
       reinterpret_cast<void*>(const_cast<PCERT_CONTEXT>(cert_handle)), 0, NULL);
   if (!valid_signature)
     return false;
   return !!CertCompareCertificateName(X509_ASN_ENCODING,
                                       &cert_handle->pCertInfo->Subject,
                                       &cert_handle->pCertInfo->Issuer);
 }
 
 }  // namespace net