Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Side by Side Diff: components/password_manager/core/browser/password_form_manager.h

Issue 2758773002: Introduce PasswordFormManager::GrabFetcher (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_ 5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_
6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_ 6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 const base::string16& generation_field); 241 const base::string16& generation_field);
242 242
243 FormSaver* form_saver() { return form_saver_.get(); } 243 FormSaver* form_saver() { return form_saver_.get(); }
244 244
245 // Clears references to matches derived from the associated FormFetcher data. 245 // Clears references to matches derived from the associated FormFetcher data.
246 // After calling this, the PasswordFormManager holds no references to objects 246 // After calling this, the PasswordFormManager holds no references to objects
247 // owned by the associated FormFetcher. This does not cause removing |this| as 247 // owned by the associated FormFetcher. This does not cause removing |this| as
248 // a consumer of |form_fetcher_|. 248 // a consumer of |form_fetcher_|.
249 void ResetStoredMatches(); 249 void ResetStoredMatches();
250 250
251 // Takes ownership of |fetcher|. 251 // Takes ownership of |fetcher|. If |fetcher| is different from the current
252 // TODO(crbug.com/621355) Until https://codereview.chromium.org/2758773002/, 252 // |form_fetcher_| then also resets matches stored from the old fetcher and
253 // |fetcher.get()| must be the same as |form_fetcher_|. 253 // adds itself as a consumer of the new one.
254 void GrabFetcher(std::unique_ptr<FormFetcher> fetcher); 254 void GrabFetcher(std::unique_ptr<FormFetcher> fetcher);
255 255
256 protected: 256 protected:
257 // FormFetcher::Consumer: 257 // FormFetcher::Consumer:
258 void ProcessMatches( 258 void ProcessMatches(
259 const std::vector<const autofill::PasswordForm*>& non_federated, 259 const std::vector<const autofill::PasswordForm*>& non_federated,
260 size_t filtered_count) override; 260 size_t filtered_count) override;
261 261
262 private: 262 private:
263 // ManagerAction - What does the manager do with this form? Either it 263 // ManagerAction - What does the manager do with this form? Either it
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
577 // True if the main frame's visible URL, at the time this PasswordFormManager 577 // True if the main frame's visible URL, at the time this PasswordFormManager
578 // was created, is secure. 578 // was created, is secure.
579 bool is_main_frame_secure_ = false; 579 bool is_main_frame_secure_ = false;
580 580
581 DISALLOW_COPY_AND_ASSIGN(PasswordFormManager); 581 DISALLOW_COPY_AND_ASSIGN(PasswordFormManager);
582 }; 582 };
583 583
584 } // namespace password_manager 584 } // namespace password_manager
585 585
586 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_ 586 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698