Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2758683003: Revert of Android: Support Android Studio 2.3 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by estevenson
Modified:
6 months, 1 week ago
Reviewers:
Peter Wen, awdf
CC:
chromium-reviews, mikecase+watch_chromium.org, nyquist+watch_chromium.org, jbudorick+watch_chromium.org, wnwen+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Android: Support Android Studio 2.3 (patchset #2 id:20001 of https://codereview.chromium.org/2746103004/ ) Reason for revert: Breaks code editing in Android Studio, see http://crbug/700438 for more info. Original issue's description: > Android: Support Android Studio 2.3 > > Also fixes excludes filters not working. For files whose directory is > not fully included in the target, add those individually instead. > > BUG=700438 > > Review-Url: https://codereview.chromium.org/2746103004 > Cr-Commit-Position: refs/heads/master@{#457093} > Committed: https://chromium.googlesource.com/chromium/src/+/f9fca7ca0225a5c4ef021046526bf75e2cade80d TBR=wnwen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=700438 Review-Url: https://codereview.chromium.org/2758683003 Cr-Commit-Position: refs/heads/master@{#457866} Committed: https://chromium.googlesource.com/chromium/src/+/136f215ed31f9e748b388b5e79bf0e4888f62acc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -24 lines) Patch
M build/android/gradle/android.jinja View 1 chunk +5 lines, -3 lines 0 comments Download
M build/android/gradle/generate_gradle.py View 7 chunks +40 lines, -18 lines 0 comments Download
M build/android/gradle/root.jinja View 1 chunk +1 line, -1 line 0 comments Download
M docs/android_studio.md View 1 chunk +1 line, -2 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 12 (6 generated)
estevenson
Created Revert of Android: Support Android Studio 2.3
6 months, 1 week ago (2017-03-17 15:38:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758683003/1
6 months, 1 week ago (2017-03-17 15:41:20 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/252563)
6 months, 1 week ago (2017-03-17 16:18:16 UTC) #5
estevenson
6 months, 1 week ago (2017-03-17 17:16:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758683003/1
6 months, 1 week ago (2017-03-17 17:19:29 UTC) #9
commit-bot: I haz the power
6 months, 1 week ago (2017-03-17 20:00:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/136f215ed31f9e748b388b5e79bf...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b