Android: Support Android Studio 2.3

Android: Support Android Studio 2.3

Also fixes excludes filters not working. For files whose directory is
not fully included in the target, add those individually instead.

BUG=700438
Review-Url: https://codereview.chromium.org/2746103004
Cr-Commit-Position: refs/heads/master@{#457093}
Committed: https://chromium.googlesource.com/chromium/src/+/f9fca7ca0225a5c4ef021046526bf75e2cade80d

[Peter Wen, 2017-03-14 19:46:25]

wnwen@chromium.org changed reviewers:
+ estevenson@chromium.org

[Peter Wen, 2017-03-14 19:46:26]

PTAL. :)

[estevenson, 2017-03-14 23:41:49]

lgtm!

https://codereview.chromium.org/2746103004/diff/1/build/android/gradle/genera...
File build/android/gradle/generate_gradle.py (right):

https://codereview.chromium.org/2746103004/diff/1/build/android/gradle/genera...
build/android/gradle/generate_gradle.py:420:
single_files.update(missing_java_files)
Does this ever happen? Doesn't missing_java_files contain a set of files that we
couldn't find, and therefore would cause problems when we tell Android Studio to
look for them?

https://codereview.chromium.org/2746103004/diff/1/build/android/gradle/genera...
build/android/gradle/generate_gradle.py:499: variables['build_tools_version'] =
'25.0.0'
I was still prompted with an error about having the wrong version of build tools
- is that supposed to happen? If you don't see it, maybe do a git clean -df from
third_party/android_tools and try syncing again. 

After updating it works as expected but should we add a note to the "what works"
section to let devs know that this is normal?

[Peter Wen, 2017-03-15 14:42:49]

Thanks for the review!

https://codereview.chromium.org/2746103004/diff/1/build/android/gradle/genera...
File build/android/gradle/generate_gradle.py (right):

https://codereview.chromium.org/2746103004/diff/1/build/android/gradle/genera...
build/android/gradle/generate_gradle.py:420:
single_files.update(missing_java_files)
On 2017/03/14 23:41:49, estevenson wrote:
> Does this ever happen? Doesn't missing_java_files contain a set of files that
we
> couldn't find, and therefore would cause problems when we tell Android Studio
to
> look for them?

Done. Changed from warning to error message. No reason to add them.

https://codereview.chromium.org/2746103004/diff/1/build/android/gradle/genera...
build/android/gradle/generate_gradle.py:499: variables['build_tools_version'] =
'25.0.0'
On 2017/03/14 23:41:49, estevenson wrote:
> I was still prompted with an error about having the wrong version of build
tools
> - is that supposed to happen? If you don't see it, maybe do a git clean -df
from
> third_party/android_tools and try syncing again. 
> 
> After updating it works as expected but should we add a note to the "what
works"
> section to let devs know that this is normal?

Makes sense, added to docs.

[Peter Wen, 2017-03-15 14:42:56]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2017-03-15 14:42:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
estevenson@chromium.org
Link to the patchset: https://codereview.chromium.org/2746103004/#ps20001
(title: "Fix per review.")

[commit-bot: I haz the power, 2017-03-15 14:43:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 15:47:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489588976221730,
"parent_rev": "096d6486506097d8737060760ade12aac69f4d4e", "commit_rev":
"f9fca7ca0225a5c4ef021046526bf75e2cade80d"}

[commit-bot: I haz the power, 2017-03-15 15:48:16]

Description was changed from

==========
Android: Support Android Studio 2.3

Also fixes excludes filters not working. For files whose directory is
not fully included in the target, add those individually instead.

BUG=700438
==========

to

==========
Android: Support Android Studio 2.3

Also fixes excludes filters not working. For files whose directory is
not fully included in the target, add those individually instead.

BUG=700438

Review-Url: https://codereview.chromium.org/2746103004
Cr-Commit-Position: refs/heads/master@{#457093}
Committed:
https://chromium.googlesource.com/chromium/src/+/f9fca7ca0225a5c4ef021046526b...
==========

[commit-bot: I haz the power, 2017-03-15 15:48:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f9fca7ca0225a5c4ef021046526b...

[estevenson, 2017-03-17 15:38:45]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2758683003/ by estevenson@chromium.org.

The reason for reverting is: Breaks code editing in Android Studio, see
http://crbug/700438 for more info..