Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2758673002: [DevTools] Extract NetworkLog and HAREntry to a separate network_log module (Closed)

Created:
8 months ago by dgozman
Modified:
8 months ago
Reviewers:
caseq
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Extract NetworkLog and HAREntry to a separate network_log module These should be separated from sdk as presentation models. BUG=none Review-Url: https://codereview.chromium.org/2758673002 Cr-Commit-Position: refs/heads/master@{#457930} Committed: https://chromium.googlesource.com/chromium/src/+/84e9516dcbbc2e25aeb7fd50d5458938c3fc456e

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -784 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/resource-har-conversion.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/resource-har-headers.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/resource-parameters.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/resource-parameters-ipv6.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/async-callstack-network-initiator-image.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/initial-modules-load-expected.txt View 5 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/network/network-status-non-http.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/AuditController.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/module.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/Linkifier.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/module.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console_model/module.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/module.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/inspector.json View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/module.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/HARWriter.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/module.json View 1 chunk +2 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/network_log/HAREntry.js View 10 chunks +13 lines, -13 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/network_log/NetworkLog.js View 14 chunks +35 lines, -35 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/network_log/module.json View 1 chunk +2 lines, -1 line 0 comments Download
D third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js View 1 chunk +0 lines, -353 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js View 1 chunk +0 lines, -343 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/module.json View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
dgozman
Could you please take a look?
8 months ago (2017-03-17 01:01:03 UTC) #2
caseq
lgtm
8 months ago (2017-03-17 17:57:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758673002/1
8 months ago (2017-03-17 19:08:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/172680) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
8 months ago (2017-03-17 19:11:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758673002/20001
8 months ago (2017-03-17 21:08:35 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/403223)
8 months ago (2017-03-17 23:08:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758673002/20001
8 months ago (2017-03-17 23:11:03 UTC) #14
commit-bot: I haz the power
8 months ago (2017-03-18 02:25:30 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/84e9516dcbbc2e25aeb7fd50d545...

Powered by Google App Engine
This is Rietveld efc10ee0f