third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js - Issue 2758673002: [DevTools] Extract NetworkLog and HAREntry to a separate network_log module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 2758673002: [DevTools] Extract NetworkLog and HAREntry to a separate network_log module (Closed)

Patch Set: rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/HARWriter.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

index de19a4764e85353e513cd683fd707dfc301e93c2..d20d161eceeec402c6636bae4315e93c0a7a6222 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

@@ -298,8 +298,8 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {

var bRequest = b.requestOrFirstKnownChildRequest();

if (!aRequest || !bRequest)

return !aRequest ? -1 : 1;

- var aInitiator = SDK.networkLog.initiatorInfoForRequest(aRequest);

- var bInitiator = SDK.networkLog.initiatorInfoForRequest(bRequest);

+ var aInitiator = NetworkLog.networkLog.initiatorInfoForRequest(aRequest);

+ var bInitiator = NetworkLog.networkLog.initiatorInfoForRequest(bRequest);

if (aInitiator.type < bInitiator.type)

return -1;

@@ -469,7 +469,7 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {

showingInitiatorChainChanged() {

var showInitiatorChain = this.showingInitiatorChain();

- var initiatorGraph = SDK.networkLog.initiatorGraphForRequest(this._request);

+ var initiatorGraph = NetworkLog.networkLog.initiatorGraphForRequest(this._request);

for (var request of initiatorGraph.initiators) {

if (request === this._request)

continue;

@@ -676,7 +676,7 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {

willAttach() {

if (this._initiatorCell &&

- SDK.networkLog.initiatorInfoForRequest(this._request).type === SDK.NetworkRequest.InitiatorType.Script)

+ NetworkLog.networkLog.initiatorInfoForRequest(this._request).type === SDK.NetworkRequest.InitiatorType.Script)

this._initiatorCell.insertBefore(this._linkifiedInitiatorAnchor, this._initiatorCell.firstChild);

}

@@ -810,7 +810,7 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {

_renderInitiatorCell(cell) {

this._initiatorCell = cell;

var request = this._request;

- var initiator = SDK.networkLog.initiatorInfoForRequest(request);

+ var initiator = NetworkLog.networkLog.initiatorInfoForRequest(request);

if (request.timing && request.timing.pushStart)

cell.appendChild(createTextNode(Common.UIString('Push / ')));