Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2758663003: Always include flow thread overflow in the last column set. (Closed)

Created:
3 years, 9 months ago by mstensho (USE GERRIT)
Modified:
3 years, 9 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always include flow thread overflow in the last column set. Also do this if the last column set is followed by one or more column spanner placeholders, or we'd just risk losing content in such situations. BUG=699029 Review-Url: https://codereview.chromium.org/2758663003 Cr-Commit-Position: refs/heads/master@{#457882} Committed: https://chromium.googlesource.com/chromium/src/+/481b60f33d1b0985a3bce0ea0b55a9d054add218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/span/after-float.html View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/span/after-float-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/span/float-with-margin-at-row-boundary-before-spanner-crash.html View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mstensho (USE GERRIT)
3 years, 9 months ago (2017-03-17 20:24:09 UTC) #6
eae
OK, LGTM
3 years, 9 months ago (2017-03-17 20:44:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758663003/1
3 years, 9 months ago (2017-03-17 20:44:49 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 20:51:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/481b60f33d1b0985a3bce0ea0b55...

Powered by Google App Engine
This is Rietveld 408576698