third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp - Issue 2758663003: Always include flow thread overflow in the last column set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp

Issue 2758663003: Always include flow thread overflow in the last column set. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/span/float-with-margin-at-row-boundary-before-spanner-crash.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp

index 4925afa3a5f17a4c8a34c19f15032eaa7e687226..f9d9851997e038d68f5898e97fc3f35d7f46ea86 100644

--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp

@@ -1308,10 +1308,11 @@ void LayoutMultiColumnFlowThread::layout() {

LayoutFlowThread::layout();

if (LayoutMultiColumnSet* lastSet = lastMultiColumnSet()) {

ASSERT(lastSet == m_lastSetWorkedOn);

- if (!lastSet->nextSiblingMultiColumnBox()) {

- // Include trailing overflow in the last column set. The idea is that we

- // will generate additional columns and pages to hold that overflow, since

- // people do write bad content like <body style="height:0px"> in

+ if (!lastSet->nextSiblingMultiColumnSet()) {

+ // Include trailing overflow in the last column set (also if the last set

+ // is followed by one or more spanner placeholders). The idea is that we

+ // will generate additional columns and pages to hold that overflow,

+ // since people do write bad content like <body style="height:0px"> in

// multi-column layouts.

// TODO(mstensho): Once we support nested multicol, adding in overflow

// here may result in the need for creating additional rows, since there