Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2758493003: Support the full `request` attribute types for the BGFetchManager.fetch() (Closed)

Created:
3 years, 9 months ago by Peter Beverloo
Modified:
3 years, 9 months ago
Reviewers:
haraken, harkness
CC:
chromium-reviews, awdf+watch_chromium.org, Peter Beverloo, blink-reviews-bindings_chromium.org, blink-reviews, harkness+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support the full `request` attribute types for the BGFetchManager.fetch() Raphael kindly improved the bindings generator to support nested union types, so we can now properly support this! BUG=700370 Review-Url: https://codereview.chromium.org/2758493003 Cr-Commit-Position: refs/heads/master@{#457446} Committed: https://chromium.googlesource.com/chromium/src/+/293b1855e6df88132db0ff0f5dd55ff835f8d7c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M third_party/WebKit/Source/bindings/modules/v8/generated.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.idl View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Peter Beverloo
+haraken for bindings/modules/v8/generated.gni addition +harkness for review We're not yet using the attribute, but it'll ...
3 years, 9 months ago (2017-03-16 14:05:01 UTC) #2
haraken
bindings LGTM
3 years, 9 months ago (2017-03-16 14:05:40 UTC) #5
harkness
lgtm
3 years, 9 months ago (2017-03-16 14:10:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758493003/1
3 years, 9 months ago (2017-03-16 15:46:08 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 15:53:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/293b1855e6df88132db0ff0f5dd5...

Powered by Google App Engine
This is Rietveld 408576698