third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp - Issue 2758493003: Support the full `request` attribute types for the BGFetchManager.fetch()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp

Issue 2758493003: Support the full `request` attribute types for the BGFetchManager.fetch() (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h ('k') | third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp

diff --git a/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp b/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp

index a1339f50c9bf2c09e144a890e6488f00270952ba..3cff35c4f43fe20ee78ee8ad22d6782167cad668 100644

--- a/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp

+++ b/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp

@@ -22,7 +22,7 @@ BackgroundFetchManager::BackgroundFetchManager(

ScriptPromise BackgroundFetchManager::fetch(

ScriptState* scriptState,

String tag,

- HeapVector<RequestOrUSVString> requests,

+ const RequestOrUSVStringOrRequestOrUSVStringSequence& requests,

const BackgroundFetchOptions& options) {

if (!m_registration->active()) {

return ScriptPromise::reject(