Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2758423002: Disable the 'Function marked forceinline not inlined.' warning on Win. (Closed)

Created:
3 years, 9 months ago by Sébastien Marchand
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Disable the 'Function marked forceinline not inlined.' warning on Win. This used to be disabled implicitly and started to broke after some refactoring in https://codereview.chromium.org/2758563002 BUG=chromium:703027 Review-Url: https://codereview.chromium.org/2758423002 Cr-Commit-Position: refs/heads/master@{#43958} Committed: https://chromium.googlesource.com/v8/v8/+/2470f2ac7193be5ec54b9c90a9df362543657c88

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Sébastien Marchand
PTAL.
3 years, 9 months ago (2017-03-20 21:28:02 UTC) #9
jochen (gone - plz use gerrit)
lgtm
3 years, 9 months ago (2017-03-20 21:34:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758423002/1
3 years, 9 months ago (2017-03-20 21:35:50 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 21:48:33 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2470f2ac7193be5ec54b9c90a9df3625436...

Powered by Google App Engine
This is Rietveld 408576698