calc() should not take Relative unit in transform-function of setMatrixValue()

calc() should not take Relative unit in transform-function of setMatrixValue()

when used calc()  in transform-function of setMatrixValue(),
calc() should not take Relative unit.
if calc() take relative unit, should be thrown a SyntaxError exception.

https://drafts.fxtf.org/geometry/#dom-dommatrix-setmatrixvalue

BUG=702959
Review-Url: https://codereview.chromium.org/2758153002
Cr-Commit-Position: refs/heads/master@{#458247}
Committed: https://chromium.googlesource.com/chromium/src/+/cc6b59309149c3bff4a8c7eb57252d7323fab0dd

[Hwanseung Lee, 2017-03-19 11:05:48]

Description was changed from

==========
check RelativeUnit inside calc() function in setMatrix().

BUG=
==========

to

==========
calc() should not take Relative unit in transform-function of setMatrixValue()

when used calc()  in transform-function of setMatrixValue(),
calc() should not take Relative unit.
if calc() take relative unit, should be thrown a SyntaxError exception.

https://drafts.fxtf.org/geometry/#dom-dommatrix-setmatrixvalue

BUG=702959
==========

[Hwanseung Lee, 2017-03-19 11:21:57]

hs1217.lee@samsung.com changed reviewers:
+ meade@chromium.org, timloh@chromium.org

[Hwanseung Lee, 2017-03-19 11:21:57]

@timolh, meade
PTAL, thank you.

[Timothy Loh, 2017-03-20 00:42:29]

timloh@chromium.org changed reviewers:
+ alancutter@chromium.org
- timloh@chromium.org

[Timothy Loh, 2017-03-20 00:42:30]

I no longer work on style code, adding alancutter@ who I think is still the
owner of calc().

[alancutter (OOO until 2018), 2017-03-20 00:56:19]

lgtm with nit.

https://codereview.chromium.org/2758153002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-setMatrixValue.html
(left):

https://codereview.chromium.org/2758153002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-setMatrixValue.html:232:
// }, "DOMMatrix setMatrix(multiple value)");
For future reference we should not check in commented out code. Instead this
should have been checked in with failing expectations.

https://codereview.chromium.org/2758153002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp (right):

https://codereview.chromium.org/2758153002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp:115:
resolvedType == CSSPrimitiveValue::UnitType::Unknown) {
Add test coverage for non-px non-relative lengths and using percent lengths.

[Hwanseung Lee, 2017-03-20 13:52:13]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 13:52:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-03-20 14:10:06]

https://codereview.chromium.org/2758153002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-setMatrixValue.html
(left):

https://codereview.chromium.org/2758153002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-setMatrixValue.html:232:
// }, "DOMMatrix setMatrix(multiple value)");
On 2017/03/20 00:56:19, alancutter wrote:
> For future reference we should not check in commented out code. Instead this
> should have been checked in with failing expectations.

actually, failing expectation was existed.
(https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/dom/...).

but following to your guide, i added more failing cases.

https://codereview.chromium.org/2758153002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp (right):

https://codereview.chromium.org/2758153002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp:115:
resolvedType == CSSPrimitiveValue::UnitType::Unknown) {
On 2017/03/20 00:56:19, alancutter wrote:
> Add test coverage for non-px non-relative lengths and using percent lengths.

Done.

[Hwanseung Lee, 2017-03-20 14:28:02]

hs1217.lee@samsung.com changed reviewers:
+ suzyh@chromium.org

[Hwanseung Lee, 2017-03-20 14:32:28]

@suzyh
PTAL. could you review this patch? thank you.

[commit-bot: I haz the power, 2017-03-20 15:20:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 15:20:44]

Dry run: This issue passed the CQ dry run.

[suzyh_UTC10 (ex-contributor), 2017-03-20 22:44:12]

lgtm

[Hwanseung Lee, 2017-03-20 23:58:59]

The CQ bit was checked by hs1217.lee@samsung.com

[Hwanseung Lee, 2017-03-20 23:59:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2758153002/#ps20001
(title: "add test case")

[commit-bot: I haz the power, 2017-03-20 23:59:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 00:06:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490054339586960,
"parent_rev": "9c4b2005a536042afa175da68877b8f3d241380c", "commit_rev":
"cc6b59309149c3bff4a8c7eb57252d7323fab0dd"}

[commit-bot: I haz the power, 2017-03-21 00:08:10]

Description was changed from

==========
calc() should not take Relative unit in transform-function of setMatrixValue()

when used calc()  in transform-function of setMatrixValue(),
calc() should not take Relative unit.
if calc() take relative unit, should be thrown a SyntaxError exception.

https://drafts.fxtf.org/geometry/#dom-dommatrix-setmatrixvalue

BUG=702959
==========

to

==========
calc() should not take Relative unit in transform-function of setMatrixValue()

when used calc()  in transform-function of setMatrixValue(),
calc() should not take Relative unit.
if calc() take relative unit, should be thrown a SyntaxError exception.

https://drafts.fxtf.org/geometry/#dom-dommatrix-setmatrixvalue

BUG=702959

Review-Url: https://codereview.chromium.org/2758153002
Cr-Commit-Position: refs/heads/master@{#458247}
Committed:
https://chromium.googlesource.com/chromium/src/+/cc6b59309149c3bff4a8c7eb5725...
==========

[commit-bot: I haz the power, 2017-03-21 00:08:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cc6b59309149c3bff4a8c7eb5725...