calc() should not take Relative unit in transform-function of setMatrixValue()

third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc.
  * All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
@@ skipping 89 matching lines @@
   }
 }
 
 bool TransformBuilder::hasRelativeLengths(const CSSValueList& valueList) {
   for (auto& value : valueList) {
     const CSSFunctionValue* transformValue = toCSSFunctionValue(value.get());
 
     for (const CSSValue* item : *transformValue) {
       const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(*item);
 
-      // TODO(hs1217.lee) : to prevent relative unit like calc(10px + 1em).
-      // but when calc() not take parameter of ralative unit like calc(1px +1
-      // px),
-      // shoud be return false;
       if (primitiveValue.isCalculated()) {
-        return true;
+        CSSCalcValue* cssCalcValue = primitiveValue.cssCalcValue();
+        CSSPrimitiveValue::UnitType resolvedType =
+            cssCalcValue->expressionNode()->typeWithCalcResolved();
+        if (CSSPrimitiveValue::isRelativeUnit(resolvedType) ||
+            resolvedType == CSSPrimitiveValue::UnitType::Unknown) {

[alancutter (OOO until 2018), 2017/03/20 00:56:19]

Add test coverage for non-px non-relative lengths and using percent lengths.

[Hwanseung Lee, 2017/03/20 14:10:06]

Done.

+          return true;
+        }
       }
 
       if (CSSPrimitiveValue::isRelativeUnit(
               primitiveValue.typeWithCalcResolved())) {
         return true;
       }
     }
   }
   return false;
 }
@@ skipping 209 matching lines @@
       }
       default:
         ASSERT_NOT_REACHED();
         break;
     }
   }
   return operations;
 }
 
 }  // namespace blink