Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2758013002: drm: Rename DRM_FORMAT_YV12 to DRM_FORMAT_YVU420. (Closed)

Created:
3 years, 9 months ago by Daniele Castagna
Modified:
3 years, 9 months ago
Reviewers:
dnicoara, reveman
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

drm: Rename DRM_FORMAT_YV12 to DRM_FORMAT_YVU420. The YVU 420 format is defined in libdrm as DRM_FORMAT_YVU420. We had defined it in Chromium as DRM_FORMAT_YV12. This CL removes the definition where it is not necessary and renames it to DRM_FORMAT_YVU420 where the drm_fourcc.h definition can't be used. BUG=702750 Review-Url: https://codereview.chromium.org/2758013002 Cr-Commit-Position: refs/heads/master@{#458282} Committed: https://chromium.googlesource.com/chromium/src/+/45f5535aa5697764029717c37eb4606f26522db1

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove DRM_FORMAT_YV12 define. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M ui/gl/gl_image_native_pixmap.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/common/drm_util.cc View 1 3 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Daniele Castagna
3 years, 9 months ago (2017-03-17 20:48:33 UTC) #2
reveman
lgtm
3 years, 9 months ago (2017-03-17 23:12:41 UTC) #7
dnicoara
lgtm https://codereview.chromium.org/2758013002/diff/1/ui/ozone/platform/drm/common/drm_util.cc File ui/ozone/platform/drm/common/drm_util.cc (right): https://codereview.chromium.org/2758013002/diff/1/ui/ozone/platform/drm/common/drm_util.cc#newcode20 ui/ozone/platform/drm/common/drm_util.cc:20: #if !defined(DRM_FORMAT_YV12) Can we remove this then?
3 years, 9 months ago (2017-03-20 14:39:47 UTC) #8
Daniele Castagna
https://codereview.chromium.org/2758013002/diff/1/ui/ozone/platform/drm/common/drm_util.cc File ui/ozone/platform/drm/common/drm_util.cc (right): https://codereview.chromium.org/2758013002/diff/1/ui/ozone/platform/drm/common/drm_util.cc#newcode20 ui/ozone/platform/drm/common/drm_util.cc:20: #if !defined(DRM_FORMAT_YV12) On 2017/03/20 at 14:39:47, dnicoara wrote: > ...
3 years, 9 months ago (2017-03-21 01:11:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758013002/20001
3 years, 9 months ago (2017-03-21 02:06:44 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 02:18:46 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/45f5535aa5697764029717c37eb4...

Powered by Google App Engine
This is Rietveld 408576698