Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp

Issue 2757883002: Revert "Pull AudioDestinationConsumer off the Blink GC heap." (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp
diff --git a/third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp b/third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp
index 5e19c39fd20ed9fb8b2bfabdcd8682025d3aa56e..56e5e5a700545a3c0899526c25890e62a626dacc 100644
--- a/third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp
+++ b/third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp
@@ -148,8 +148,6 @@ bool WebMediaStreamSource::requiresAudioConsumer() const {
}
class ConsumerWrapper final : public AudioDestinationConsumer {
- USING_FAST_MALLOC(ConsumerWrapper);
-
public:
static ConsumerWrapper* create(WebAudioDestinationConsumer* consumer) {
return new ConsumerWrapper(consumer);
@@ -198,10 +196,12 @@ bool WebMediaStreamSource::removeAudioConsumer(
ASSERT(isMainThread());
ASSERT(!m_private.isNull() && consumer);
- const HashSet<AudioDestinationConsumer*>& consumers =
+ const HeapHashSet<Member<AudioDestinationConsumer>>& consumers =
m_private->audioConsumers();
- for (AudioDestinationConsumer* it : consumers) {
- ConsumerWrapper* wrapper = static_cast<ConsumerWrapper*>(it);
+ for (HeapHashSet<Member<AudioDestinationConsumer>>::const_iterator it =
+ consumers.begin();
+ it != consumers.end(); ++it) {
+ ConsumerWrapper* wrapper = static_cast<ConsumerWrapper*>(it->get());
if (wrapper->consumer() == consumer) {
m_private->removeAudioConsumer(wrapper);
return true;

Powered by Google App Engine
This is Rietveld 408576698