Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2893)

Issue 2757723002: Update ICE protocol to handle closed channel (Closed)

Created:
3 years, 4 months ago by Sergey Ulanov
Modified:
3 years, 4 months ago
Reviewers:
joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update ICE protocol to handle closed channel An ICE/PseudoTcp channel may be closed by the peer. Read() may returns 0 in that case. MessageReader wasn't expecting 0 and was DCHECK'ing in that case. Also update StreamMessagePipeAdapter to handle this case as closed MessagePipe. BUG=700167 Review-Url: https://codereview.chromium.org/2757723002 Cr-Commit-Position: refs/heads/master@{#457842} Committed: https://chromium.googlesource.com/chromium/src/+/5b4667bc57d3ce2230e556ba38dcdc9342bdf819

Patch Set 1 : . #

Total comments: 6

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -62 lines) Patch
M remoting/protocol/connection_tester.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M remoting/protocol/connection_tester.cc View 1 chunk +52 lines, -22 lines 0 comments Download
M remoting/protocol/fake_session.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M remoting/protocol/fake_stream_socket.h View 3 chunks +3 lines, -2 lines 0 comments Download
M remoting/protocol/fake_stream_socket.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M remoting/protocol/ice_connection_to_client.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M remoting/protocol/ice_connection_to_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/protocol/message_reader.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/protocol/message_reader_unittest.cc View 2 chunks +13 lines, -1 line 0 comments Download
M remoting/protocol/stream_message_pipe_adapter.h View 2 chunks +4 lines, -2 lines 0 comments Download
M remoting/protocol/stream_message_pipe_adapter.cc View 1 2 chunks +23 lines, -15 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Sergey Ulanov
3 years, 4 months ago (2017-03-17 00:07:33 UTC) #6
joedow
lgtm https://codereview.chromium.org/2757723002/diff/40001/remoting/protocol/connection_tester.cc File remoting/protocol/connection_tester.cc (right): https://codereview.chromium.org/2757723002/diff/40001/remoting/protocol/connection_tester.cc#newcode304 remoting/protocol/connection_tester.cc:304: MessagePipe* client_pipe, The order of host/client pipe args ...
3 years, 4 months ago (2017-03-17 15:13:28 UTC) #7
Sergey Ulanov
https://codereview.chromium.org/2757723002/diff/40001/remoting/protocol/connection_tester.cc File remoting/protocol/connection_tester.cc (right): https://codereview.chromium.org/2757723002/diff/40001/remoting/protocol/connection_tester.cc#newcode304 remoting/protocol/connection_tester.cc:304: MessagePipe* client_pipe, On 2017/03/17 15:13:28, joedow wrote: > The ...
3 years, 4 months ago (2017-03-17 18:18:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757723002/60001
3 years, 4 months ago (2017-03-17 18:19:21 UTC) #11
commit-bot: I haz the power
3 years, 4 months ago (2017-03-17 19:13:41 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5b4667bc57d3ce2230e556ba38dc...

Powered by Google App Engine
This is Rietveld 408576698