remoting/protocol/ice_connection_to_host.cc - Issue 2757723002: Update ICE protocol to handle closed channel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/protocol/ice_connection_to_host.cc

Issue 2757723002: Update ICE protocol to handle closed channel (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/protocol/ice_connection_to_host.cc

diff --git a/remoting/protocol/ice_connection_to_host.cc b/remoting/protocol/ice_connection_to_host.cc

index 535aa76bb49cf914f840fe70d111b963b4134e1b..4fa7eae06a6648dc1720ef61a5541169340f140e 100644

--- a/remoting/protocol/ice_connection_to_host.cc

+++ b/remoting/protocol/ice_connection_to_host.cc

@@ -175,8 +175,7 @@ void IceConnectionToHost::OnChannelInitialized(

void IceConnectionToHost::OnChannelClosed(

ChannelDispatcherBase* channel_dispatcher) {

- // ICE transport doesn't close channels dynamically.

- NOTREACHED();

+ session_->Close(OK);

}

void IceConnectionToHost::OnVideoChannelStatus(bool active) {

« no previous file with comments | « remoting/protocol/ice_connection_to_client.cc ('k') | remoting/protocol/message_reader.cc » ('j') | no next file with comments »