Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2757573004: Move the WebCacheManager call from BrowsingDataRemoverImpl to the delegate (Closed)

Created:
3 years, 9 months ago by msramek
Modified:
3 years, 9 months ago
Reviewers:
Mike West
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the WebCacheManager call from BrowsingDataRemoverImpl to the delegate ...since WebCacheManager has a dependency on content/browser, and thus cannot be used from BrowsingDataRemoverImpl once it moves there. BUG=668114 Review-Url: https://codereview.chromium.org/2757573004 Cr-Commit-Position: refs/heads/master@{#458367} Committed: https://chromium.googlesource.com/chromium/src/+/dfe95153bd3532636ab0badcf624c3caaa197099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M chrome/browser/browsing_data/browsing_data_remover_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
msramek
Hi Mike, Please have a look at this one as well :) Medium-term, I'll be ...
3 years, 9 months ago (2017-03-17 19:37:19 UTC) #6
Mike West
LGTM.
3 years, 9 months ago (2017-03-18 06:14:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757573004/1
3 years, 9 months ago (2017-03-21 09:24:52 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 10:38:03 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dfe95153bd3532636ab0badcf624...

Powered by Google App Engine
This is Rietveld 408576698