Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc

Issue 2757573004: Move the WebCacheManager call from BrowsingDataRemoverImpl to the delegate (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browsing_data/browsing_data_remover_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
diff --git a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
index e03e934c76bb7dd548ded351dc30bd0ad2781ed2..50b98b6bf9f443a09c6b389b21a949327987f295 100644
--- a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
+++ b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
@@ -65,6 +65,7 @@
#include "components/search_engines/template_url_service.h"
#include "components/sessions/core/tab_restore_service.h"
#include "components/translate/core/browser/language_model.h"
+#include "components/web_cache/browser/web_cache_manager.h"
#include "content/public/browser/browsing_data_filter_builder.h"
#include "content/public/browser/plugin_data_remover.h"
#include "content/public/browser/ssl_host_state_delegate.h"
@@ -799,6 +800,14 @@ void ChromeBrowsingDataRemoverDelegate::RemoveEmbedderData(
//////////////////////////////////////////////////////////////////////////////
// DATA_TYPE_CACHE
if (remove_mask & BrowsingDataRemover::DATA_TYPE_CACHE) {
+ // Tell the renderers to clear their cache.
+ // TODO(crbug.com/668114): Renderer cache is a platform concept, and should
+ // live in BrowsingDataRemoverImpl. However, WebCacheManager itself is
+ // a component with dependency on content/browser. Untangle these
+ // dependencies or reimplement the relevant part of WebCacheManager
+ // in content/browser.
+ web_cache::WebCacheManager::GetInstance()->ClearCache();
+
#if !defined(DISABLE_NACL)
clear_nacl_cache_.Start();
« no previous file with comments | « chrome/browser/browsing_data/browsing_data_remover_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698