Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2757573002: Revert of Initialize document m_URL, m_baseURL to blankURL. (Closed)

Created:
3 years, 9 months ago by tzik
Modified:
3 years, 9 months ago
Reviewers:
tkent, MartinRogalla
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Initialize document m_URL, m_baseURL to blankURL. (patchset #4 id:60001 of https://codereview.chromium.org/2749803003/ ) Reason for revert: This CL seems to break interactive_ui_tests on multiple bots: A sample of error log was: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/44135 ../../chrome/test/base/extension_js_browser_test.cc:64: Failure Failed Failed: RUN_TEST_F("AutomationTreeWalkerTest","Backward") ReferenceError: DesktopAutomationHandler is not defined at AutomationTreeWalkerTest.ChromeVoxNextE2ETest (tree_walker_test.extjs:8556:3) at AutomationTreeWalkerTest (tree_walker_test.extjs:8663:24) at createTestCase (tree_walker_test.extjs:7607:19) at RUN_TEST_F (tree_walker_test.extjs:7721:25) at tree_walker_test.extjs:7523:20 at runTestFunction (tree_walker_test.extjs:7593:37) at runTest (tree_walker_test.extjs:7567:18) at tree_walker_test.extjs:8851:1 gen/chrome/browser/resources/chromeos/chromevox/cvox2/background/tree_walker_test-gen.cc:69: Failure Value of: RunJavascriptTestF( true, "AutomationTreeWalkerTest", "Backward") Actual: false Expected: true [ FAILED ] AutomationTreeWalkerTest.Backward, where TypeParam = and GetParam() = (1196 ms) Original issue's description: > Initialize document m_URL & m_baseURL to blankURL. > > This patch will ensure that m_URL and m_baseURL are initialized to > blankURL (about:blank) as is specified in [1]. This patch fixes the > tests in [2] and [3]. > > [1] https://dom.spec.whatwg.org/#interface-document > [2] http://w3c-test.org/dom/nodes/DOMImplementation-createDocument.html > [3] http://w3c-test.org/dom/nodes/DOMImplementation-createHTMLDocument.html > > BUG=563986 > > Review-Url: https://codereview.chromium.org/2749803003 > Cr-Commit-Position: refs/heads/master@{#457347} > Committed: https://chromium.googlesource.com/chromium/src/+/9168f165fe92e37664a5e39fef987f0e3ad72a62 TBR=tkent@chromium.org,martin@martinrogalla.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=563986 Review-Url: https://codereview.chromium.org/2757573002 Cr-Commit-Position: refs/heads/master@{#457366} Committed: https://chromium.googlesource.com/chromium/src/+/2d05f4450c89d4ff77990fc736637e9a21cf90a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1512 lines, -126 lines) Patch
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentgetdocumenturi02.js View 1 chunk +112 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentgetdocumenturi02.xhtml View 1 chunk +73 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentgetdocumenturi03.js View 1 chunk +118 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentgetdocumenturi03.xhtml View 1 chunk +73 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentgetdocumenturi03-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentsetdocumenturi03.js View 1 chunk +117 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentsetdocumenturi03.xhtml View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentsetdocumenturi03-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/nodegetbaseuri02.js View 1 chunk +119 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/nodegetbaseuri02.xhtml View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/nodegetbaseuri02-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt View 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/DOMImplementation-createDocument-expected.txt View 6 chunks +91 lines, -91 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/dom/nodes/DOMImplementation-createHTMLDocument-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Node-cloneNode-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Node-properties-expected.txt View 1 chunk +703 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/document-attribute-js-null.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/document-attribute-js-null-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/location-new-window-no-crash.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/location-new-window-no-crash-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.11/external/wpt/dom/interfaces-expected.txt View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-retina/external/wpt/dom/interfaces-expected.txt View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/external/wpt/dom/interfaces-expected.txt View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tzik
Created Revert of Initialize document m_URL, m_baseURL to blankURL.
3 years, 9 months ago (2017-03-16 06:31:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757573002/1
3 years, 9 months ago (2017-03-16 06:32:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2d05f4450c89d4ff77990fc736637e9a21cf90a4
3 years, 9 months ago (2017-03-16 06:34:32 UTC) #6
tkent
3 years, 9 months ago (2017-03-16 06:42:09 UTC) #7
Message was sent while issue was closed.
I'm not sure if the CL is related to the failures.  anyway, lgtm to try to
revert it.

Powered by Google App Engine
This is Rietveld 408576698