Chromium Code Reviews
Help | Chromium Project | Sign in
(96)

Issue 2757563006: Floats are also out-of-flow considering white-space. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 4 days ago by rune
Modified:
1 week, 4 days ago
Reviewers:
mstensho
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Floats are also out-of-flow considering white-space. When blocks in inlines break lines, we don't create LayoutObjects for whitespace Text nodes following those blocks unless they are out-of-flow. However, we incorrectly didn't skip floats looking for such blocks which caused us to drop whitespace LayoutObjects after floats. R=mstensho@opera.com BUG=569786 Review-Url: https://codereview.chromium.org/2757563006 Cr-Commit-Position: refs/heads/master@{#457762} Committed: https://chromium.googlesource.com/chromium/src/+/fb45b47dfa3c3c7f40c5b5b6c4d06a9de480f49d

Patch Set 1 #

Patch Set 2 : Fixed test expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/fast/block/float/float-before-whitespace-inside-inline.html View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/block/float/float-before-whitespace-inside-inline-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/html/layout-runs-and-floats-crash-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/selectors/style-sharing-last-child-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/invalidation-errors-2-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/invalidation-errors-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/layers/remove-layer-with-nested-stacking-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug7113-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/css/invalidation-errors-2-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/css/invalidation-errors-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/layers/remove-layer-with-nested-stacking-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug7113-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/css/invalidation-errors-2-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/css/invalidation-errors-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/layers/remove-layer-with-nested-stacking-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug7113-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/fast/css/invalidation-errors-2-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/fast/css/invalidation-errors-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Text.cpp View 1 chunk +1 line, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 15 (9 generated)
rune
ptal
1 week, 4 days ago (2017-03-17 10:30:48 UTC) #2
mstensho
lgtm, but ye mighte consider spelling "Howevere" differently. :)
1 week, 4 days ago (2017-03-17 10:54:05 UTC) #4
rune
So what fails now is that we are adding whitespace layout objects which weren't there ...
1 week, 4 days ago (2017-03-17 12:24:58 UTC) #7
mstensho
lgtm^2
1 week, 4 days ago (2017-03-17 12:51:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757563006/20001
1 week, 4 days ago (2017-03-17 13:05:25 UTC) #12
commit-bot: I haz the power
1 week, 4 days ago (2017-03-17 14:34:31 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fb45b47dfa3c3c7f40c5b5b6c4d0...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46