Floats are also out-of-flow considering white-space.

Floats are also out-of-flow considering white-space.

When blocks in inlines break lines, we don't create LayoutObjects for
whitespace Text nodes following those blocks unless they are out-of-flow.
However, we incorrectly didn't skip floats looking for such blocks
which caused us to drop whitespace LayoutObjects after floats.

R=mstensho@opera.com
BUG=569786
Review-Url: https://codereview.chromium.org/2757563006
Cr-Commit-Position: refs/heads/master@{#457762}
Committed: https://chromium.googlesource.com/chromium/src/+/fb45b47dfa3c3c7f40c5b5b6c4d06a9de480f49d

[rune, 2017-03-17 10:30:38]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[rune, 2017-03-17 10:30:48]

ptal

[commit-bot: I haz the power, 2017-03-17 10:30:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mstensho (USE GERRIT), 2017-03-17 10:54:05]

lgtm, but ye mighte consider spelling "Howevere" differently. :)

[commit-bot: I haz the power, 2017-03-17 11:59:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 11:59:58]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[rune, 2017-03-17 12:24:58]

So what fails now is that we are adding whitespace layout objects which weren't
there before and are not strictly needed, like in:

  <span> <div style="float:right></div> </span>

We now create a layout object for both whitespace nodes. That is in line with
what was already there for absolute positioned boxes like:

  <span> <div style="position:absolute"></div> </span>

I think that is an acceptable regression. In order to fix that with the current
code, we'd potentially need to walk N layout object siblings to find out if we
really need that whitespace layout object if we have N preceding float siblings
which gives us more O(N^2) issues than we already have.

[rune, 2017-03-17 12:25:12]

Description was changed from

==========
Floats are also out-of-flow considering white-space.

When blocks in inlines break lines, we don't create LayoutObjects for
whitespace Text nodes following those blocks unless they are out-of-flow.
Howevere, we incorrectly didn't skip floats looking for such blocks
which caused us to drop whitespace LayoutObjects after floats.

R=mstensho@opera.com
BUG=569786
==========

to

==========
Floats are also out-of-flow considering white-space.

When blocks in inlines break lines, we don't create LayoutObjects for
whitespace Text nodes following those blocks unless they are out-of-flow.
However, we incorrectly didn't skip floats looking for such blocks
which caused us to drop whitespace LayoutObjects after floats.

R=mstensho@opera.com
BUG=569786
==========

[mstensho (USE GERRIT), 2017-03-17 12:51:39]

lgtm^2

[rune, 2017-03-17 13:05:11]

The CQ bit was checked by rune@opera.com

[rune, 2017-03-17 13:05:11]

The patchset sent to the CQ was uploaded after l-g-t-m from mstensho@opera.com
Link to the patchset: https://codereview.chromium.org/2757563006/#ps20001
(title: "Fixed test expectations.")

[commit-bot: I haz the power, 2017-03-17 13:05:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 14:33:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489755911420910,
"parent_rev": "2291f94252fe3921fee1a5039708553e14141b68", "commit_rev":
"fb45b47dfa3c3c7f40c5b5b6c4d06a9de480f49d"}

[commit-bot: I haz the power, 2017-03-17 14:34:30]

Description was changed from

==========
Floats are also out-of-flow considering white-space.

When blocks in inlines break lines, we don't create LayoutObjects for
whitespace Text nodes following those blocks unless they are out-of-flow.
However, we incorrectly didn't skip floats looking for such blocks
which caused us to drop whitespace LayoutObjects after floats.

R=mstensho@opera.com
BUG=569786
==========

to

==========
Floats are also out-of-flow considering white-space.

When blocks in inlines break lines, we don't create LayoutObjects for
whitespace Text nodes following those blocks unless they are out-of-flow.
However, we incorrectly didn't skip floats looking for such blocks
which caused us to drop whitespace LayoutObjects after floats.

R=mstensho@opera.com
BUG=569786

Review-Url: https://codereview.chromium.org/2757563006
Cr-Commit-Position: refs/heads/master@{#457762}
Committed:
https://chromium.googlesource.com/chromium/src/+/fb45b47dfa3c3c7f40c5b5b6c4d0...
==========

[commit-bot: I haz the power, 2017-03-17 14:34:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fb45b47dfa3c3c7f40c5b5b6c4d0...