Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(21)

Issue 2757543006: DevTools: remove dead frontend_url param from DevToolsWindow::Create. (Closed)

Created:
8 months ago by pfeldman
Modified:
8 months ago
Reviewers:
paulirish, dgozman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove dead frontend_url param from DevToolsWindow::Create. Review-Url: https://codereview.chromium.org/2757543006 Cr-Commit-Position: refs/heads/master@{#458165} Committed: https://chromium.googlesource.com/chromium/src/+/5ee95709dd07c47f2a794eb1cf14762274b678b9

Patch Set 1 #

Messages

Total messages: 12 (6 generated)
pfeldman
8 months ago (2017-03-17 03:36:03 UTC) #2
dgozman
lgtm
8 months ago (2017-03-17 17:33:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757543006/1
8 months ago (2017-03-20 19:03:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/302376) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
8 months ago (2017-03-20 19:24:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757543006/1
8 months ago (2017-03-20 19:33:15 UTC) #9
commit-bot: I haz the power
8 months ago (2017-03-20 20:22:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ee95709dd07c47f2a794eb1cf14...

Powered by Google App Engine
This is Rietveld efc10ee0f