Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2757543006: DevTools: remove dead frontend_url param from DevToolsWindow::Create. (Closed)

Created:
3 years, 9 months ago by pfeldman
Modified:
3 years, 9 months ago
Reviewers:
paulirish, dgozman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove dead frontend_url param from DevToolsWindow::Create. Review-Url: https://codereview.chromium.org/2757543006 Cr-Commit-Position: refs/heads/master@{#458165} Committed: https://chromium.googlesource.com/chromium/src/+/5ee95709dd07c47f2a794eb1cf14762274b678b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -25 lines) Patch
M chrome/browser/devtools/devtools_window.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 8 chunks +15 lines, -23 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
pfeldman
3 years, 9 months ago (2017-03-17 03:36:03 UTC) #2
dgozman
lgtm
3 years, 9 months ago (2017-03-17 17:33:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757543006/1
3 years, 9 months ago (2017-03-20 19:03:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/302376) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 9 months ago (2017-03-20 19:24:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757543006/1
3 years, 9 months ago (2017-03-20 19:33:15 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 20:22:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ee95709dd07c47f2a794eb1cf14...

Powered by Google App Engine
This is Rietveld 408576698