Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Issue 2757543003: Reland of [Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part 2/3 (Closed)

Created:
3 years, 9 months ago by clamy
Modified:
3 years, 9 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part 2/3 (patchset #1 id:1 of https://codereview.chromium.org/2757563002/ ) Reason for revert: The CL reverted was part of a two-sided CL, and the downstream part landed just before this got reverted. So the Android ToT roller bot is broken again. Let's land this CL again, so that everything goes back to green. Original issue's description: > Revert of [Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part 2/3 (patchset #2 id:20001 of https://codereview.chromium.org/2728053002/ ) > > Reason for revert: > This is causing build failures on clang-clankium-tot-builder > See: > https://crbug.com/702086 > https://uberchromegw.corp.google.com/i/internal.client.clank_tot/builders/clang-clankium-tot-builder/builds/43251 > > Original issue's description: > > [Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part 2/3 > > > > This CL: > > - Changes GooglePlayWebApkInstallDelegate#installAsync() to return a > > WebApkInstallResult in the callback. > > - Deletes unused GooglePlayWebApkInstallDelegate#canInstallWebApk(). > > > > BUG=696132 > > > > Review-Url: https://codereview.chromium.org/2728053002 > > Cr-Commit-Position: refs/heads/master@{#457300} > > Committed: https://chromium.googlesource.com/chromium/src/+/19d929ae378491116d7683764baa6365d1ddd50d > > TBR=dominickn@chromium.org,pkotwicz@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=696132 > > Review-Url: https://codereview.chromium.org/2757563002 > Cr-Commit-Position: refs/heads/master@{#457361} > Committed: https://chromium.googlesource.com/chromium/src/+/6da294d05e78dcdd1109ae8dc763ea0485c714af TBR=dominickn@chromium.org,pkotwicz@chromium.org,aelias@chromium.org,cblume@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=696132 Review-Url: https://codereview.chromium.org/2757543003 Cr-Commit-Position: refs/heads/master@{#457402} Committed: https://chromium.googlesource.com/chromium/src/+/0b8414c122248ea1db697651dee163f7517216dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -22 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/GooglePlayWebApkInstallDelegate.java View 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java View 2 chunks +8 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
clamy
Created Reland of [Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part ...
3 years, 9 months ago (2017-03-16 12:11:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757543003/1
3 years, 9 months ago (2017-03-16 12:11:17 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 12:12:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0b8414c122248ea1db697651dee1...

Powered by Google App Engine
This is Rietveld 408576698