Restrict use of GN target //media/base/android:android

Restrict use of GN target //media/base/android:android

As //media/base/android:android is a source_set, multiple targets referencing
it using DEPS result in multiple copies of the code being used when
is_component_build = true. Adding a visibility restriction to the target,
and changing all users to use //media (which should be the only target
including the code).

BUG=702438
TEST=gn check passes
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2757463004
Cr-Commit-Position: refs/heads/master@{#458207}
Committed: https://chromium.googlesource.com/chromium/src/+/397905b7040fa1c0329d3675bcfd1120c04d7867

[jrummell, 2017-03-17 00:46:55]

Description was changed from

==========
Restrict use of GN target //media/base/android:android

As //media/base/android:android is a source_set, multiple targets referencing
it using DEPS result in multiple copies of the code being used when
is_component_build = true. Adding a visibility restriction to the target,
and changing all users to use //media (which should be the only target
including the code).

BUG=702438
TEST=gn check passes
==========

to

==========
Restrict use of GN target //media/base/android:android

As //media/base/android:android is a source_set, multiple targets referencing
it using DEPS result in multiple copies of the code being used when
is_component_build = true. Adding a visibility restriction to the target,
and changing all users to use //media (which should be the only target
including the code).

BUG=702438
TEST=gn check passes
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jrummell, 2017-03-17 00:47:24]

The CQ bit was checked by jrummell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 00:47:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 00:58:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 00:58:22]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[jrummell, 2017-03-17 17:56:09]

The CQ bit was checked by jrummell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 17:56:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 19:38:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 19:38:26]

Dry run: This issue passed the CQ dry run.

[jrummell, 2017-03-17 20:00:51]

jrummell@chromium.org changed reviewers:
+ brettw@chromium.org, halliwell@chromium.org, sgurun@chromium.org,
xhwang@chromium.org

[jrummell, 2017-03-17 20:00:52]

PTAL. Minor change since //media will have the necessary dependencies, and
nobody should reference //media/base/android:android anymore.

sgurun@ for android, halliwell@ for cast, brettw@ for content, xhwang@ for
media.

[xhwang, 2017-03-17 23:24:07]

LGTM with nits, thanks for the fix!

https://codereview.chromium.org/2757463004/diff/20001/content/gpu/BUILD.gn
File content/gpu/BUILD.gn (right):

https://codereview.chromium.org/2757463004/diff/20001/content/gpu/BUILD.gn#ne...
content/gpu/BUILD.gn:63: "//media/gpu/ipc/service",
Add a TODO to revisit this one later.

https://codereview.chromium.org/2757463004/diff/20001/media/blink/BUILD.gn
File media/blink/BUILD.gn (right):

https://codereview.chromium.org/2757463004/diff/20001/media/blink/BUILD.gn#ne...
media/blink/BUILD.gn:154: "//media",
we already have this on line 112

[halliwell, 2017-03-17 23:24:38]

On 2017/03/17 23:24:07, xhwang_slow wrote:
> LGTM with nits, thanks for the fix!
> 
> https://codereview.chromium.org/2757463004/diff/20001/content/gpu/BUILD.gn
> File content/gpu/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2757463004/diff/20001/content/gpu/BUILD.gn#ne...
> content/gpu/BUILD.gn:63: "//media/gpu/ipc/service",
> Add a TODO to revisit this one later.
> 
> https://codereview.chromium.org/2757463004/diff/20001/media/blink/BUILD.gn
> File media/blink/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2757463004/diff/20001/media/blink/BUILD.gn#ne...
> media/blink/BUILD.gn:154: "//media",
> we already have this on line 112

chromecast/ lgtm

[jrummell, 2017-03-17 23:45:38]

Updated.

https://codereview.chromium.org/2757463004/diff/20001/content/gpu/BUILD.gn
File content/gpu/BUILD.gn (right):

https://codereview.chromium.org/2757463004/diff/20001/content/gpu/BUILD.gn#ne...
content/gpu/BUILD.gn:63: "//media/gpu/ipc/service",
On 2017/03/17 23:24:07, xhwang_slow wrote:
> Add a TODO to revisit this one later.

Done.

https://codereview.chromium.org/2757463004/diff/20001/media/blink/BUILD.gn
File media/blink/BUILD.gn (right):

https://codereview.chromium.org/2757463004/diff/20001/media/blink/BUILD.gn#ne...
media/blink/BUILD.gn:154: "//media",
On 2017/03/17 23:24:07, xhwang_slow wrote:
> we already have this on line 112

Done.

[sgurun-gerrit only, 2017-03-20 19:27:36]

On 2017/03/17 23:45:38, jrummell (OOO until Apr 3) wrote:
> Updated.
> 
> https://codereview.chromium.org/2757463004/diff/20001/content/gpu/BUILD.gn
> File content/gpu/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2757463004/diff/20001/content/gpu/BUILD.gn#ne...
> content/gpu/BUILD.gn:63: "//media/gpu/ipc/service",
> On 2017/03/17 23:24:07, xhwang_slow wrote:
> > Add a TODO to revisit this one later.
> 
> Done.
> 
> https://codereview.chromium.org/2757463004/diff/20001/media/blink/BUILD.gn
> File media/blink/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2757463004/diff/20001/media/blink/BUILD.gn#ne...
> media/blink/BUILD.gn:154: "//media",
> On 2017/03/17 23:24:07, xhwang_slow wrote:
> > we already have this on line 112
> 
> Done.

aw lgtm

[brettw, 2017-03-20 19:42:48]

lgtm

[xhwang, 2017-03-20 19:52:53]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2017-03-20 19:52:53]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org,
halliwell@chromium.org
Link to the patchset: https://codereview.chromium.org/2757463004/#ps40001
(title: "changes")

[commit-bot: I haz the power, 2017-03-20 19:53:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 20:45:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 20:45:18]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[xhwang, 2017-03-20 21:18:02]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2017-03-20 21:19:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 22:36:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490044682952950,
"parent_rev": "cdfbc720d88e1151d3684a7f12804d372ecbb138", "commit_rev":
"397905b7040fa1c0329d3675bcfd1120c04d7867"}

[commit-bot: I haz the power, 2017-03-20 22:37:18]

Description was changed from

==========
Restrict use of GN target //media/base/android:android

As //media/base/android:android is a source_set, multiple targets referencing
it using DEPS result in multiple copies of the code being used when
is_component_build = true. Adding a visibility restriction to the target,
and changing all users to use //media (which should be the only target
including the code).

BUG=702438
TEST=gn check passes
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Restrict use of GN target //media/base/android:android

As //media/base/android:android is a source_set, multiple targets referencing
it using DEPS result in multiple copies of the code being used when
is_component_build = true. Adding a visibility restriction to the target,
and changing all users to use //media (which should be the only target
including the code).

BUG=702438
TEST=gn check passes
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2757463004
Cr-Commit-Position: refs/heads/master@{#458207}
Committed:
https://chromium.googlesource.com/chromium/src/+/397905b7040fa1c0329d3675bcfd...
==========

[commit-bot: I haz the power, 2017-03-20 22:37:19]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/397905b7040fa1c0329d3675bcfd...