Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: media/base/android/BUILD.gn

Issue 2757463004: Restrict use of GN target //media/base/android:android (Closed)
Patch Set: changes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/BUILD.gn ('k') | media/blink/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/BUILD.gn
diff --git a/media/base/android/BUILD.gn b/media/base/android/BUILD.gn
index 9b17610fabea3f0407f465900339decd4eb77822..afbf2215f5283c3e4be2430c309e68ec9c70ec07 100644
--- a/media/base/android/BUILD.gn
+++ b/media/base/android/BUILD.gn
@@ -10,9 +10,11 @@ import("//media/media_options.gni")
if (is_android) {
import("//build/config/android/rules.gni")
- # APK targets that depend on this, either directly or indirectly, should also
+ # This is bundled into //media, so all dependencies should be on //media.
+ # APK targets that depend on this indirectly, should also
# depend on :media_java to get the corresponding Java classes.
source_set("android") {
+ visibility = [ "//media/base:base" ]
sources = [
"android_cdm_factory.cc",
"android_cdm_factory.h",
@@ -68,6 +70,7 @@ if (is_android) {
source_set("unit_tests") {
testonly = true
+ visibility = [ "//media/base:unit_tests" ]
sources = [
"media_codec_bridge_impl_unittest.cc",
"media_codec_loop_unittest.cc",
@@ -80,7 +83,7 @@ if (is_android) {
]
deps = [
- ":android",
+ "//media",
"//media/base:test_support",
"//testing/gmock",
"//testing/gtest",
« no previous file with comments | « media/BUILD.gn ('k') | media/blink/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698