Make ScopedURLFetcherFactory sequenced-safe.

Make ScopedURLFetcherFactory sequenced-safe.

This CL allows ScopedURLFetcherFactory to be used in a test
environment exposing a sequenced task runner instead of
requiring a single thread task runner, a relaxation of the
requirements (single thread is a stricter instance of a
sequened task runner).

The URL fetcher code has already been relaxed in a previous
CL to only require a sequenced runner, but the corresponding
update to ScopedURLFetcherFactory was overlooked.

BUG=675631
Review-Url: https://codereview.chromium.org/2757233003
Cr-Commit-Position: refs/heads/master@{#458201}
Committed: https://chromium.googlesource.com/chromium/src/+/770b36c2734d41edbb8d5b260bcfc9c29fe16afd

[Roger McFarlane (Chromium), 2017-03-20 19:38:33]

The CQ bit was checked by rogerm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 19:38:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roger McFarlane (Chromium), 2017-03-20 19:43:01]

The CQ bit was checked by rogerm@chromium.org to run a CQ dry run

[Roger McFarlane (Chromium), 2017-03-20 19:43:08]

The CQ bit was unchecked by rogerm@chromium.org

[Roger McFarlane (Chromium), 2017-03-20 19:43:19]

Patchset #1 (id:1) has been deleted

[Roger McFarlane (Chromium), 2017-03-20 19:44:03]

The CQ bit was checked by rogerm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 19:44:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roger McFarlane (Chromium), 2017-03-20 19:59:34]

rogerm@chromium.org changed reviewers:
+ asanka@chromium.org, fdoray@chromium.org

[Roger McFarlane (Chromium), 2017-03-20 19:59:34]

PTAL

This is a follow up to https://codereview.chromium.org/2599873002 that has been
extracted from https://codereview.chromium.org/2565873002/

[fdoray, 2017-03-20 20:22:25]

On 2017/03/20 19:59:34, Roger McFarlane (Chromium) wrote:
> PTAL
> 
> This is a follow up to https://codereview.chromium.org/2599873002 that has
been
> extracted from https://codereview.chromium.org/2565873002/

LGTM

Note: This CL is correct since SequencedTaskRunnerHandle::Get() always returns
the same thing as ThreadTaskRunnerHandle::Get(), except in cases were
ThreadTaskRunnerHandle::Get() crashes (we can safely assume that there are no
crashing ThreadTaskRunnerHandle::Get() call sites in Chrome).

[asanka, 2017-03-20 20:51:03]

lgtm

[Roger McFarlane (Chromium), 2017-03-20 20:53:40]

The CQ bit was unchecked by rogerm@chromium.org

[Roger McFarlane (Chromium), 2017-03-20 20:53:43]

The CQ bit was checked by rogerm@chromium.org

[commit-bot: I haz the power, 2017-03-20 20:54:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 22:21:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490043223640820,
"parent_rev": "ab5ed281e1f137f46e2a0d0daeda3273b04c733d", "commit_rev":
"770b36c2734d41edbb8d5b260bcfc9c29fe16afd"}

[commit-bot: I haz the power, 2017-03-20 22:23:01]

Description was changed from

==========
Make ScopedURLFetcherFactory sequenced-safe.

This CL allows ScopedURLFetcherFactory to be used in a test
environment exposing a sequenced task runner instead of
requiring a single thread task runner, a relaxation of the
requirements (single thread is a stricter instance of a
sequened task runner).

The URL fetcher code has already been relaxed in a previous
CL to only require a sequenced runner, but the corresponding
update to ScopedURLFetcherFactory was overlooked.

BUG=675631
==========

to

==========
Make ScopedURLFetcherFactory sequenced-safe.

This CL allows ScopedURLFetcherFactory to be used in a test
environment exposing a sequenced task runner instead of
requiring a single thread task runner, a relaxation of the
requirements (single thread is a stricter instance of a
sequened task runner).

The URL fetcher code has already been relaxed in a previous
CL to only require a sequenced runner, but the corresponding
update to ScopedURLFetcherFactory was overlooked.

BUG=675631

Review-Url: https://codereview.chromium.org/2757233003
Cr-Commit-Position: refs/heads/master@{#458201}
Committed:
https://chromium.googlesource.com/chromium/src/+/770b36c2734d41edbb8d5b260bcf...
==========

[commit-bot: I haz the power, 2017-03-20 22:23:02]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/770b36c2734d41edbb8d5b260bcf...