Allow URLFetcher to be used from sequenced tasks.

Allow URLFetcher to be used from sequenced tasks.

Before this CL, URLFetcher could only be instantiated from a
single-threaded task. The response was dispatched on the origin thread.

With this CL, URLFetcher can also be instantiated from a sequenced
task. The response is dispatched on the origin sequence.

Since SequencedTaskRunnerHandle behaves the same way as
ThreadTaskRunnerHandle when used from a single-threaded task, this
CL does not affect the behavior of existing URLFetcher call sites
(they are necessarily in single-threaded tasks because
base::ThreadTaskRunnerHandle::Get() crashes when called from
a non-single-threaded task).

BUG=675631
Review-Url: https://codereview.chromium.org/2599873002
Cr-Commit-Position: refs/heads/master@{#443224}
Committed: https://chromium.googlesource.com/chromium/src/+/dc3ecbb07646f4fc719f49b853ea1ef2c3a10865

[fdoray, 2016-12-22 19:21:29]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 19:21:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 20:19:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 20:19:43]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-12-23 12:35:18]

Description was changed from

==========
Allow URLFetcher to be used from sequenced tasks.

Before this CL, URLFetcher could only be instantiated from a
single-threaded task. The response was dispatched on the origin thread.

With this CL, URLFetcher can also be instantiated from a sequenced
task. The response is dispatched on the origin sequence.

Since SequencedTaskRunnerHandle behaves the same way as
ThreadTaskRunnerHandle when used from a single-threaded task, this
CL does not affect the behavior of URLFetcher when used from a
single-threaded task.

BUG=675631
==========

to

==========
Allow URLFetcher to be used from sequenced tasks.

Before this CL, URLFetcher could only be instantiated from a
single-threaded task. The response was dispatched on the origin thread.

With this CL, URLFetcher can also be instantiated from a sequenced
task. The response is dispatched on the origin sequence.

Since SequencedTaskRunnerHandle behaves the same way as
ThreadTaskRunnerHandle when used from a single-threaded task, this
CL does not affect the behavior of existing URLFetcher call sites,
which are necessarily in single-threaded tasks.

BUG=675631
==========

[fdoray, 2016-12-23 12:36:21]

Description was changed from

==========
Allow URLFetcher to be used from sequenced tasks.

Before this CL, URLFetcher could only be instantiated from a
single-threaded task. The response was dispatched on the origin thread.

With this CL, URLFetcher can also be instantiated from a sequenced
task. The response is dispatched on the origin sequence.

Since SequencedTaskRunnerHandle behaves the same way as
ThreadTaskRunnerHandle when used from a single-threaded task, this
CL does not affect the behavior of existing URLFetcher call sites,
which are necessarily in single-threaded tasks.

BUG=675631
==========

to

==========
Allow URLFetcher to be used from sequenced tasks.

Before this CL, URLFetcher could only be instantiated from a
single-threaded task. The response was dispatched on the origin thread.

With this CL, URLFetcher can also be instantiated from a sequenced
task. The response is dispatched on the origin sequence.

Since SequencedTaskRunnerHandle behaves the same way as
ThreadTaskRunnerHandle when used from a single-threaded task, this
CL does not affect the behavior of existing URLFetcher call sites
(they are necessarily in single-threaded tasks because
base::ThreadTaskRunnerHandle::Get() crashes when called from
a non-single-threaded task).

BUG=675631
==========

[fdoray, 2016-12-23 12:39:36]

fdoray@chromium.org changed reviewers:
+ agl@chromium.org

[fdoray, 2016-12-23 12:39:37]

PTAL

[fdoray, 2017-01-06 18:16:07]

fdoray@chromium.org changed reviewers:
+ gavinp@chromium.org

[fdoray, 2017-01-06 18:16:07]

+gavinp@ PTAL (no reply from agl@ after 2 weeks)

[gavinp, 2017-01-11 18:38:42]

lgtm. Sorry for being slow myself...!

https://codereview.chromium.org/2599873002/diff/1/net/url_request/url_fetcher...
File net/url_request/url_fetcher_core.cc (right):

https://codereview.chromium.org/2599873002/diff/1/net/url_request/url_fetcher...
net/url_request/url_fetcher_core.cc:127: if (delegate_task_runner_.get())  //
May be NULL in tests.
While we're here, might as well just remove the ".get()".

[fdoray, 2017-01-11 18:44:04]

https://codereview.chromium.org/2599873002/diff/1/net/url_request/url_fetcher...
File net/url_request/url_fetcher_core.cc (right):

https://codereview.chromium.org/2599873002/diff/1/net/url_request/url_fetcher...
net/url_request/url_fetcher_core.cc:127: if (delegate_task_runner_.get())  //
May be NULL in tests.
On 2017/01/11 18:38:41, gavinp wrote:
> While we're here, might as well just remove the ".get()".

Done.

[fdoray, 2017-01-11 18:44:07]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2017-01-11 18:44:07]

The patchset sent to the CQ was uploaded after l-g-t-m from gavinp@chromium.org
Link to the patchset: https://codereview.chromium.org/2599873002/#ps20001
(title: "remove get()")

[commit-bot: I haz the power, 2017-01-11 18:44:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 19:53:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 19:53:49]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[fdoray, 2017-01-12 14:07:19]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-01-12 14:07:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 14:35:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484230039638360,
"parent_rev": "91a4892f8e93dd9328e4079197404c06bcd401b7", "commit_rev":
"dc3ecbb07646f4fc719f49b853ea1ef2c3a10865"}

[commit-bot: I haz the power, 2017-01-12 14:36:01]

Description was changed from

==========
Allow URLFetcher to be used from sequenced tasks.

Before this CL, URLFetcher could only be instantiated from a
single-threaded task. The response was dispatched on the origin thread.

With this CL, URLFetcher can also be instantiated from a sequenced
task. The response is dispatched on the origin sequence.

Since SequencedTaskRunnerHandle behaves the same way as
ThreadTaskRunnerHandle when used from a single-threaded task, this
CL does not affect the behavior of existing URLFetcher call sites
(they are necessarily in single-threaded tasks because
base::ThreadTaskRunnerHandle::Get() crashes when called from
a non-single-threaded task).

BUG=675631
==========

to

==========
Allow URLFetcher to be used from sequenced tasks.

Before this CL, URLFetcher could only be instantiated from a
single-threaded task. The response was dispatched on the origin thread.

With this CL, URLFetcher can also be instantiated from a sequenced
task. The response is dispatched on the origin sequence.

Since SequencedTaskRunnerHandle behaves the same way as
ThreadTaskRunnerHandle when used from a single-threaded task, this
CL does not affect the behavior of existing URLFetcher call sites
(they are necessarily in single-threaded tasks because
base::ThreadTaskRunnerHandle::Get() crashes when called from
a non-single-threaded task).

BUG=675631

Review-Url: https://codereview.chromium.org/2599873002
Cr-Commit-Position: refs/heads/master@{#443224}
Committed:
https://chromium.googlesource.com/chromium/src/+/dc3ecbb07646f4fc719f49b853ea...
==========

[commit-bot: I haz the power, 2017-01-12 14:36:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dc3ecbb07646f4fc719f49b853ea...