Mark all IDS_FLAGS* in generated_resources.grd as translateable=false

Mark all IDS_FLAGS* in generated_resources.grd as translateable=false

Flag messages are for developers and testers, not for end users. Translating
them is therefore wasting resources and unnecessarily increasing download size
of Chrome. Marking flags messages as 'translateable="false"' has been
recommended (Google-internal only, go umoar) as an interim solution. There are
some instances of that, but having this changed for most of the messages will
make it more likely that new flag messages end up being marked in this way as
well.

This CL did the following mechanical change to generated_resources.grd:
find all message definitions with names starting with IDS_FLAGS_ and add the
translateable="false" attribute to them. There has been no other value than "false"
assigned to the 'translateable' attribute in the file, and all the IDS_FLAGS_
messages with this attribute had it as the last one. In creating the CL, all instances
of 'translateable' at the end of IDS_FLAGS_* message definitions were removed
where present, and then appended to all IDS_FLAGS_* messages. With the observations
above, this resulted in no duplicates and no conflicts in the 'translateable' value.

Furthermore, this CL adds a presubmit check for generated_resources.grd, which
flags lines containing 'name="IDS_FLAGS' and not containing 'translateable="false"'
as errors.

BUG=587272
Review-Url: https://codereview.chromium.org/2757193002
Cr-Commit-Position: refs/heads/master@{#458335}
Committed: https://chromium.googlesource.com/chromium/src/+/031786b3bb524cf552cd7faaea55ec82e1bb7f5e

[vabr (Chromium), 2017-03-20 08:10:17]

vabr@chromium.org changed reviewers:
+ agrieve@chromium.org

[vabr (Chromium), 2017-03-20 08:10:18]

Hi agrieve@,

As the owner of the associated bug, could you please review? Feel free to only
judge the general idea, I did the following thorough checks already by
inspecting the CL line by line:

(1) This only adds the 'translateable="false"' attribute, not removing anything,
not adding anything else.
(2) All affected messages seem to be flag values or descriptions.

In addition, the following follows from the regexp searches and replacements:
(3) Only messages with names starting IDS_FLAGS were changed (ensuring that
indeed just flags names and descriptions are targeted).
(4) No such message had 'translateable="false"' anywhere else than at the very
end of the HTML tag; there are no messages with duplicated translateable
attributes after this CL.
(5) No other values of the 'translateable' attributes than "false" have been
used, so the new additions do not conflict with anything.

Cheers,
Vaclav

[vabr (Chromium), 2017-03-20 08:10:27]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 08:10:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 08:12:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 08:12:31]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[vabr (Chromium), 2017-03-20 08:51:20]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 08:51:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-03-20 08:57:42]

Description was changed from

==========
Mark all IDS_FLAGS* in generated_resources.grd as translateable=false

Flag messages are for developers and testers, not for end users. Translating
them is therefore wasting resources and unnecessarily increasing download size
of Chrome. Marking flags messages as 'translateable="false"' has been
recommended (Google-internal only, go umoar) as an interim solution. There are
some instances of that, but having this changed for most of the messages will
make it more likely that new flag messages end up being marked in this way as
well.

This CL did the following mechanical change: find all message definitions in
generated_resources.grd with names starting with IDS_FLAGS_ and add the
translateable="false" attribute to them.

BUG=587272
==========

to

==========
Mark all IDS_FLAGS* in generated_resources.grd as translateable=false

Flag messages are for developers and testers, not for end users. Translating
them is therefore wasting resources and unnecessarily increasing download size
of Chrome. Marking flags messages as 'translateable="false"' has been
recommended (Google-internal only, go umoar) as an interim solution. There are
some instances of that, but having this changed for most of the messages will
make it more likely that new flag messages end up being marked in this way as
well.

This CL did the following mechanical change to generated_resources.grd:
find all message definitions with names starting with IDS_FLAGS_ and add the
translateable="false" attribute to them. There has been no other value than
"false"
assigned to the 'translateable' attribute in the file, and all the IDS_FLAGS_
messages with this attribute had it as the last one. In creating the CL, all
instances
of 'translateable' at the end of IDS_FLAGS_* message definitions were removed
where present, and then appended to all IDS_FLAGS_* messages. With the
observations
above, this resulted in no duplicates and no conflicts in the 'translateable'
value.

Furthermore, this CL adds a presubmit check for generated_resources.grd, which
flags lines containing 'name="IDS_FLAGS' and not containing
'translateable="false"'
as errors.

BUG=587272
==========

[vabr (Chromium), 2017-03-20 08:57:42]

vabr@chromium.org changed reviewers:
+ jochen@chromium.org

[vabr (Chromium), 2017-03-20 09:00:08]

Hi jochen@,

Because you suggested the presubmit check, could you please review my change to
PRESUBMIT.py?

Also, please review the the general idea of the change to
generated_resources.grd. I already did the
following thorough checks by inspecting the CL line by line:

(1) This only adds the 'translateable="false"' attribute, not removing anything,
not adding anything else.
(2) All affected messages seem to be flag values or descriptions.

Cheers,
Vaclav

[jochen (gone - plz use gerrit), 2017-03-20 09:06:30]

lgtm

[vabr (Chromium), 2017-03-20 09:09:50]

Thanks, Jochen!

@agrieve -- given Jochen's approval, you no longer need to review.
As promised on the internal mailing list, I will still wait until tomorrow with
landing this to allow people, including you, to object to this change.

Cheers,
Vaclav

[vabr (Chromium), 2017-03-20 09:10:07]

vabr@chromium.org changed reviewers:
- agrieve@chromium.org

[commit-bot: I haz the power, 2017-03-20 09:30:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 09:30:15]

Dry run: This issue passed the CQ dry run.

[agrieve, 2017-03-20 14:09:43]

agrieve@chromium.org changed reviewers:
+ agrieve@chromium.org

[agrieve, 2017-03-20 14:09:44]

lgtm

https://codereview.chromium.org/2757193002/diff/20001/chrome/app/PRESUBMIT.py
File chrome/app/PRESUBMIT.py (right):

https://codereview.chromium.org/2757193002/diff/20001/chrome/app/PRESUBMIT.py...
chrome/app/PRESUBMIT.py:38: """Check that no about:flags are marked as not
requiring translation.
nit: Check that *all* about:flags ...

[agrieve, 2017-03-20 14:09:59]

On 2017/03/20 14:09:44, agrieve wrote:
> lgtm
> 
> https://codereview.chromium.org/2757193002/diff/20001/chrome/app/PRESUBMIT.py
> File chrome/app/PRESUBMIT.py (right):
> 
>
https://codereview.chromium.org/2757193002/diff/20001/chrome/app/PRESUBMIT.py...
> chrome/app/PRESUBMIT.py:38: """Check that no about:flags are marked as not
> requiring translation.
> nit: Check that *all* about:flags ...

(also - thanks for doing this!)

[srahim, 2017-03-20 17:40:36]

srahim@chromium.org changed reviewers:
+ srahim@chromium.org

[srahim, 2017-03-20 17:40:36]

LGTM and thank you for doing this!

[vabr (Chromium), 2017-03-20 19:03:28]

Thank you for review!

I addressed the comment and will do a CQ dry run. I will land this tomorrow
morning, following my promise to wait 24h in the original e-mail.

Cheers,
Vaclav

https://codereview.chromium.org/2757193002/diff/20001/chrome/app/PRESUBMIT.py
File chrome/app/PRESUBMIT.py (right):

https://codereview.chromium.org/2757193002/diff/20001/chrome/app/PRESUBMIT.py...
chrome/app/PRESUBMIT.py:38: """Check that no about:flags are marked as not
requiring translation.
On 2017/03/20 14:09:44, agrieve wrote:
> nit: Check that *all* about:flags ...

Thanks!
I also inserted the work "messages" after about:flags, which I lost by accident
and then replaced "that" with a semicolon to get the line under 80 characters.

[vabr (Chromium), 2017-03-20 20:09:15]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 20:09:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 21:13:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 21:13:34]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2017-03-21 07:05:51]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2017-03-21 07:05:51]

The patchset sent to the CQ was uploaded after l-g-t-m from srahim@chromium.org,
jochen@chromium.org, agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2757193002/#ps40001
(title: "Rebased and fixed a comment in the PRESUBMIT.py")

[commit-bot: I haz the power, 2017-03-21 07:06:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 07:12:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490079951346250,
"parent_rev": "14d44e70cf6e529d5cd1ae82364c2ce7ec444ae9", "commit_rev":
"031786b3bb524cf552cd7faaea55ec82e1bb7f5e"}

[commit-bot: I haz the power, 2017-03-21 07:13:58]

Description was changed from

==========
Mark all IDS_FLAGS* in generated_resources.grd as translateable=false

Flag messages are for developers and testers, not for end users. Translating
them is therefore wasting resources and unnecessarily increasing download size
of Chrome. Marking flags messages as 'translateable="false"' has been
recommended (Google-internal only, go umoar) as an interim solution. There are
some instances of that, but having this changed for most of the messages will
make it more likely that new flag messages end up being marked in this way as
well.

This CL did the following mechanical change to generated_resources.grd:
find all message definitions with names starting with IDS_FLAGS_ and add the
translateable="false" attribute to them. There has been no other value than
"false"
assigned to the 'translateable' attribute in the file, and all the IDS_FLAGS_
messages with this attribute had it as the last one. In creating the CL, all
instances
of 'translateable' at the end of IDS_FLAGS_* message definitions were removed
where present, and then appended to all IDS_FLAGS_* messages. With the
observations
above, this resulted in no duplicates and no conflicts in the 'translateable'
value.

Furthermore, this CL adds a presubmit check for generated_resources.grd, which
flags lines containing 'name="IDS_FLAGS' and not containing
'translateable="false"'
as errors.

BUG=587272
==========

to

==========
Mark all IDS_FLAGS* in generated_resources.grd as translateable=false

Flag messages are for developers and testers, not for end users. Translating
them is therefore wasting resources and unnecessarily increasing download size
of Chrome. Marking flags messages as 'translateable="false"' has been
recommended (Google-internal only, go umoar) as an interim solution. There are
some instances of that, but having this changed for most of the messages will
make it more likely that new flag messages end up being marked in this way as
well.

This CL did the following mechanical change to generated_resources.grd:
find all message definitions with names starting with IDS_FLAGS_ and add the
translateable="false" attribute to them. There has been no other value than
"false"
assigned to the 'translateable' attribute in the file, and all the IDS_FLAGS_
messages with this attribute had it as the last one. In creating the CL, all
instances
of 'translateable' at the end of IDS_FLAGS_* message definitions were removed
where present, and then appended to all IDS_FLAGS_* messages. With the
observations
above, this resulted in no duplicates and no conflicts in the 'translateable'
value.

Furthermore, this CL adds a presubmit check for generated_resources.grd, which
flags lines containing 'name="IDS_FLAGS' and not containing
'translateable="false"'
as errors.

BUG=587272

Review-Url: https://codereview.chromium.org/2757193002
Cr-Commit-Position: refs/heads/master@{#458335}
Committed:
https://chromium.googlesource.com/chromium/src/+/031786b3bb524cf552cd7faaea55...
==========

[commit-bot: I haz the power, 2017-03-21 07:14:00]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/031786b3bb524cf552cd7faaea55...