Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2757183002: Fix the download summary notification icons (Closed)

Created:
3 years, 9 months ago by David Trainor- moved to gerrit
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix the download summary notification icons Make the icon ordering follow the expected behavior: progress, pending, failed, paused, completed. This requires additional changes to support listening to when completed and failed notifications are dismissed so we can update the icon state, so I added a pending intent to those delete actions as well, but prevented it from restarting the service in case it's the last notification. For proper handling of all intent actions, I still added code to handle the intent for the case where the service does get started with that action. BUG=699687 Review-Url: https://codereview.chromium.org/2751813004 Cr-Commit-Position: refs/heads/master@{#457873} (cherry picked from commit 8055a28acd2bf29534913610369be7ae1b0f894f) Review-Url: https://codereview.chromium.org/2757183002 . Cr-Commit-Position: refs/branch-heads/3029@{#288} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/a965ff59517676e50cbdf4a35c69cd26a627afda

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
David Trainor- moved to gerrit
3 years, 9 months ago (2017-03-20 05:38:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a965ff59517676e50cbdf4a35c69cd26a627afda (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698