Fix the download summary notification icons

Fix the download summary notification icons

Make the icon ordering follow the expected behavior: progress, pending,
failed, paused, completed.  This requires additional changes to support
listening to when completed and failed notifications are dismissed so we
can update the icon state, so I added a pending intent to those delete
actions as well, but prevented it from restarting the service in case
it's the last notification.  For proper handling of all intent actions,
I still added code to handle the intent for the case where the service
does get started with that action.

BUG=699687
Review-Url: https://codereview.chromium.org/2751813004
Cr-Commit-Position: refs/heads/master@{#457873}
Committed: https://chromium.googlesource.com/chromium/src/+/8055a28acd2bf29534913610369be7ae1b0f894f

[David Trainor- moved to gerrit, 2017-03-16 00:05:10]

dtrainor@chromium.org changed reviewers:
+ qinmin@chromium.org

[David Trainor- moved to gerrit, 2017-03-16 00:05:11]

ptal thanks!

https://codereview.chromium.org/2751813004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/2751813004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:188:
private static void updateSummaryIcon(Context context, NotificationManager
manager,
Made these calls static and had them take in a NotificationManager to minimize
context.getSystemService calls.  They should cache the service internally but
it's not really correct to rely on that assumption.

[David Trainor- moved to gerrit, 2017-03-17 02:58:22]

ping thanks min!  sorry for poking but want to get this in for 58.

[qinmin, 2017-03-17 04:41:59]

lgtm

[David Trainor- moved to gerrit, 2017-03-17 07:42:42]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[David Trainor- moved to gerrit, 2017-03-17 07:50:31]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 07:50:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 08:20:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 08:20:18]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[David Trainor- moved to gerrit, 2017-03-17 19:30:52]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 19:31:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 20:09:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 20:09:32]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2017-03-17 20:10:15]

The CQ bit was checked by dtrainor@chromium.org

[David Trainor- moved to gerrit, 2017-03-17 20:10:16]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org
Link to the patchset: https://codereview.chromium.org/2751813004/#ps40001
(title: "Fixed test compile error")

[commit-bot: I haz the power, 2017-03-17 20:10:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 20:18:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489781415917010,
"parent_rev": "75c75092b256d5e3e0ae7ecafd1f8b3430246e1b", "commit_rev":
"8055a28acd2bf29534913610369be7ae1b0f894f"}

[commit-bot: I haz the power, 2017-03-17 20:19:01]

Description was changed from

==========
Fix the download summary notification icons

Make the icon ordering follow the expected behavior: progress, pending,
failed, paused, completed.  This requires additional changes to support
listening to when completed and failed notifications are dismissed so we
can update the icon state, so I added a pending intent to those delete
actions as well, but prevented it from restarting the service in case
it's the last notification.  For proper handling of all intent actions,
I still added code to handle the intent for the case where the service
does get started with that action.

BUG=699687
==========

to

==========
Fix the download summary notification icons

Make the icon ordering follow the expected behavior: progress, pending,
failed, paused, completed.  This requires additional changes to support
listening to when completed and failed notifications are dismissed so we
can update the icon state, so I added a pending intent to those delete
actions as well, but prevented it from restarting the service in case
it's the last notification.  For proper handling of all intent actions,
I still added code to handle the intent for the case where the service
does get started with that action.

BUG=699687

Review-Url: https://codereview.chromium.org/2751813004
Cr-Commit-Position: refs/heads/master@{#457873}
Committed:
https://chromium.googlesource.com/chromium/src/+/8055a28acd2bf29534913610369b...
==========

[commit-bot: I haz the power, 2017-03-17 20:19:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8055a28acd2bf29534913610369b...