[Android] Do not restore NTPs from disk unless they are selected.

[Android] Do not restore NTPs from disk unless they are selected.

This also disables saving tab states for NTPs as they are not
needed for tab restore anyway (the metadata file will restore
based on URL if the state file is missing and can handle the
NTP selected case anyway).

Sidenote...we should consider not persisting tab states to disk
that have no navigations nor any web contents state.

BUG=702762
Review-Url: https://codereview.chromium.org/2757013002
Cr-Commit-Position: refs/heads/master@{#458241}
Committed: https://chromium.googlesource.com/chromium/src/+/3c7d798abb3a42da2bdaeeb0497a47575fda9bd2

[Ted C, 2017-03-17 20:28:34]

tedchoc@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Ted C, 2017-03-17 20:28:34]

PTAL (dfalcantara for review, dtrainor for FYI)

[gone, 2017-03-20 17:49:04]

lgtm

https://codereview.chromium.org/2757013002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreUnitTest.java
(right):

https://codereview.chromium.org/2757013002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreUnitTest.java:101:
when(normalTabModel.index()).thenReturn(TabList.INVALID_TAB_INDEX);
Use the ones you set up in beforeTest

https://codereview.chromium.org/2757013002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreUnitTest.java:107:
when(mTabModelSelector.getModel(true)).thenReturn(incognitoTabModel);
Don't think these are necessary if you use the originals

[Ted C, 2017-03-20 17:55:54]

https://codereview.chromium.org/2757013002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreUnitTest.java
(right):

https://codereview.chromium.org/2757013002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreUnitTest.java:101:
when(normalTabModel.index()).thenReturn(TabList.INVALID_TAB_INDEX);
On 2017/03/20 17:49:03, dfalcantara (load balance plz) wrote:
> Use the ones you set up in beforeTest

Done.

https://codereview.chromium.org/2757013002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreUnitTest.java:107:
when(mTabModelSelector.getModel(true)).thenReturn(incognitoTabModel);
On 2017/03/20 17:49:03, dfalcantara (load balance plz) wrote:
> Don't think these are necessary if you use the originals

D'oh...absolutely right on both of these.  I wrote this test first and did not
clean it up when I pulled the init of the variables up.

[Ted C, 2017-03-20 17:56:10]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2017-03-20 17:56:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2757013002/#ps20001
(title: "clean up silly mistakes")

[commit-bot: I haz the power, 2017-03-20 17:56:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 19:22:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 19:22:13]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ted C, 2017-03-20 20:55:27]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2017-03-20 20:55:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2757013002/#ps40001
(title: "Fix test failure that relied on NTP being saved")

[commit-bot: I haz the power, 2017-03-20 20:56:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 23:41:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490043327021150,
"parent_rev": "70c46acd7f5117902acf57801960abc64e314825", "commit_rev":
"3c7d798abb3a42da2bdaeeb0497a47575fda9bd2"}

[commit-bot: I haz the power, 2017-03-20 23:41:51]

Description was changed from

==========
[Android] Do not restore NTPs from disk unless they are selected.

This also disables saving tab states for NTPs as they are not
needed for tab restore anyway (the metadata file will restore
based on URL if the state file is missing and can handle the
NTP selected case anyway).

Sidenote...we should consider not persisting tab states to disk
that have no navigations nor any web contents state.

BUG=702762
==========

to

==========
[Android] Do not restore NTPs from disk unless they are selected.

This also disables saving tab states for NTPs as they are not
needed for tab restore anyway (the metadata file will restore
based on URL if the state file is missing and can handle the
NTP selected case anyway).

Sidenote...we should consider not persisting tab states to disk
that have no navigations nor any web contents state.

BUG=702762

Review-Url: https://codereview.chromium.org/2757013002
Cr-Commit-Position: refs/heads/master@{#458241}
Committed:
https://chromium.googlesource.com/chromium/src/+/3c7d798abb3a42da2bdaeeb0497a...
==========

[commit-bot: I haz the power, 2017-03-20 23:41:52]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3c7d798abb3a42da2bdaeeb0497a...

[Dmitry Titov, 2017-03-21 00:20:03]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2766493002/ by dimich@chromium.org.

The reason for reverting is: Broke the compile:

https://build.chromium.org/p/chromium/builders/Android/builds/69977

.