Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java

Issue 2757013002: [Android] Do not restore NTPs from disk unless they are selected. (Closed)
Patch Set: Fix test failure that relied on NTP being saved Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
index bb31280ec3408791eaf0029435339c4c6a88f6fb..062657619d758cb338f06b144e6d8e6900f1818b 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
@@ -1805,7 +1805,13 @@ public class TabsTest extends ChromeTabbedActivityTestBase {
@Feature({"Android-TabSwitcher"})
@RetryOnFailure
public void testIncognitoTabsNotRestoredAfterSwipe() throws Exception {
+ mTestServer = EmbeddedTestServer.createAndStartServer(getInstrumentation().getContext());
+ startMainActivityWithURL(mTestServer.getURL(TEST_PAGE_FILE_PATH));
+
newIncognitoTabFromMenu();
+ // Tab states are not saved for empty NTP tabs, so navigate to any page to trigger a file
+ // to be saved.
+ loadUrl(mTestServer.getURL(TEST_PAGE_FILE_PATH));
File tabStateDir = TabbedModeTabPersistencePolicy.getOrCreateTabbedModeStateDirectory();
TabModel normalModel = getActivity().getTabModelSelector().getModel(false);
@@ -1839,7 +1845,8 @@ public class TabsTest extends ChromeTabbedActivityTestBase {
|| getName().equals("testSwitchToTabThatDoesNotHaveThumbnail")
|| getName().equals("testCloseTabPortrait")
|| getName().equals("testCloseTabLandscape")
- || getName().equals("testTabsAreDestroyedOnModelDestruction")) {
+ || getName().equals("testTabsAreDestroyedOnModelDestruction")
+ || getName().equals("testIncognitoTabsNotRestoredAfterSwipe")) {
return;
}
startMainActivityFromLauncher();

Powered by Google App Engine
This is Rietveld 408576698