Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2756963002: Purge impl-only animations awaiting deletion in AnimationPlayer::UpdateState. (Closed)

Created:
3 years, 9 months ago by skobes
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Purge impl-only animations awaiting deletion in AnimationPlayer::UpdateState. Previously, animations in WAITING_FOR_DELETION state would only be purged via AnimationPlayer::PushPropertiesTo, which synchronizes impl- and main-thread players. But the player in ScrollOffsetAnimationsImpl has no main-thread copy, so its animations never got deleted after they finished. BUG=701025 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2757453003 Cr-Commit-Position: refs/heads/master@{#457443} (cherry picked from commit e26333eb717aa94b9f05ccf34ec91bfe31927f2a) Review-Url: https://codereview.chromium.org/2756963002 . Cr-Commit-Position: refs/branch-heads/3029@{#271} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/72d4a9b5ceda4f5cca9c8c91101d92ed051c6b08

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M cc/animation/animation_player.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/animation_player.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M cc/animation/element_animations_unittest.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
skobes
3 years, 9 months ago (2017-03-17 18:18:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
72d4a9b5ceda4f5cca9c8c91101d92ed051c6b08.

Powered by Google App Engine
This is Rietveld 408576698